{RDBMS} Add support for osshf cluster #28310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ambrahma
requested review from
evelyn-ys,
DaeunYim and
calvinhzy
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
RDBMS |
microsoft-github-policy-service
bot
requested review from
yonzhan,
wangzelin007,
jsntcy and
zhoxing-ms
|
@evelyn-ys can we please have this reviewed. All checks have passed |
evelyn-ys
reviewed
Feb 18, 2024
evelyn-ys
approved these changes
Feb 20, 2024
|
This PR breaks the test, as azure-cli/src/azure-cli/setup.py Lines 177 to 178 in 5d1fea2 |
|
Fixed in #28419 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
Add support for OSSHF cluster to fetch private DNS zone domain name
Description
Add support for OSSHF cluster to fetch private DNS zone domain name
Testing Guide
Verified manually
az postgres flexible-server create -g cli-test-do-not-delete-rg-southcentralus -n cli-test-server-pg-flex-ha-vnet-southcentralus -l southcentralus --geo-redundant-backup Enabled --high-availability ZoneRedundant --vnet cli-test-osshf-pg-flex-vnet-southcentralus --subnet cli-test-osshf-pg-flex-subnet-southcentralus --private-dns-zone cli-test-osshf-pg-flex-dns-southcentralus.pg.osshf-scus1-a.mscds.com
Checking the existence of the resource group 'cli-test-do-not-delete-rg-southcentralus'...
Resource group 'cli-test-do-not-delete-rg-southcentralus' exists ? : True
You have supplied a Vnet and Subnet name. Verifying its existence...
Using existing Vnet "cli-test-osshf-pg-flex-vnet-southcentralus" in resource group "cli-test-do-not-delete-rg-southcentralus"
Using existing Subnet "cli-test-osshf-pg-flex-subnet-southcentralus" in resource group "cli-test-do-not-delete-rg-southcentralus"
Do you want to create a new private DNS zone cli-test-osshf-pg-flex-dns-southcentralus.pg.osshf-scus1-a.mscds.com in resource group cli-test-do-not-delete-rg-southcentralus (y/n): y
Creating a private dns zone cli-test-osshf-pg-flex-dns-southcentralus.pg.osshf-scus1-a.mscds.com in resource group "cli-test-do-not-delete-rg-southcentralus"
Creating PostgreSQL Server 'cli-test-server-pg-flex-ha-vnet-southcentralus' in group 'cli-test-do-not-delete-rg-southcentralus'...
Your server 'cli-test-server-pg-flex-ha-vnet-southcentralus' is using sku 'Standard_D2s_v3' (Paid Tier). Please refer to https://aka.ms/postgres-pricing for pricing details
Creating PostgreSQL database 'flexibleserverdb'...
Make a note of your password. If you forget, you would have to reset your password with "az postgres flexible-server update -n cli-test-server-pg-flex-ha-vnet-southcentralus -g cli-test-do-not-delete-rg-southcentralus -p ".
Try using 'az postgres flexible-server connect' command to test out connection.
{
"connectionString": "postgresql://giddyox2:JErrwcvummMoZ7Zxz2coyw@cli-test-server-pg-flex-ha-vnet-southcentralus.osshf-scus1-a.mscds.com/flexibleserverdb?sslmode=require",
"databaseName": "flexibleserverdb",
"host": "cli-test-server-pg-flex-ha-vnet-southcentralus.osshf-scus1-a.mscds.com",
"id": "/subscriptions/4a5d02ab-e0c3-4d39-8031-293ddd4e1875/resourceGroups/cli-test-do-not-delete-rg-southcentralus/providers/Microsoft.DBforPostgreSQL/flexibleServers/cli-test-server-pg-flex-ha-vnet-southcentralus",
"location": "South Central US",
"password": "JErrwcvummMoZ7Zxz2coyw",
"resourceGroup": "cli-test-do-not-delete-rg-southcentralus",
"skuname": "Standard_D2s_v3",
"subnetId": "/subscriptions/4a5d02ab-e0c3-4d39-8031-293ddd4e1875/resourceGroups/cli-test-do-not-delete-rg-southcentralus/providers/Microsoft.Network/virtualNetworks/cli-test-osshf-pg-flex-vnet-southcentralus/subnets/cli-test-osshf-pg-flex-subnet-southcentralus",
"username": "giddyox2",
"version": "13"
}
This checklist is used to make sure that common guidelines for a pull request are followed.
[X ] The PR title and description has followed the guideline in Submitting Pull Requests.
[X ] I adhere to the Command Guidelines.
[X ] I adhere to the Error Handling Guidelines.