{RDBMS} Add support for osshf cluster (#28310)

* Add support for osshf cluster

* Fix pylint errors

* Fix missing cluster in json error

* Fix CLI errors

* Fix too generic exception error

* Add osshf support for CLI in northcentralus

* Avoid key error in case of reading for cloud from json file

Author: ambrahma

src/azure-cli/azure/cli/command_modules/rdbms/_config_reader.py

@@ -0,0 +1,42 @@
+# --------------------------------------------------------------------------------------------
+# Copyright (c) Microsoft Corporation. All rights reserved.
+# Licensed under the MIT License. See License.txt in the project root for license information.
+# --------------------------------------------------------------------------------------------
+
+import json
+import os
+from azure.cli.core.azclierror import BadRequestError
+
+_config = None
+
+
+def get_config_json():
+    global _config  # pylint:disable=global-statement
+    if _config is not None:
+        return _config
+    script_dir = os.path.dirname(os.path.realpath(__file__))
+    with open(os.path.join(script_dir, "config.json"), "r") as f:
+        try:
+            _config = json.load(f)
+            return _config
+        except ValueError:
+            raise BadRequestError("Invalid json file. Make sure that the json file content is properly formatted.")
+
+
+def get_cloud(cmd):
+    config = get_config_json()
+    return config[cmd.cli_ctx.cloud.name]
+
+
+def get_cloud_cluster(cmd, location, subscription_id):
+    try:
+        cloud = get_cloud(cmd)
+        clusters = cloud[location]
+    except KeyError:
+        clusters = None
+    if clusters is not None:
+        for cluster in clusters:
+            if cloud[cluster] is not None:
+                if subscription_id in cloud[cluster]["subscriptions"]:
+                    return cloud[cluster]
+    return

src/azure-cli/azure/cli/command_modules/rdbms/config.json

@@ -0,0 +1,26 @@
+{
+    "AzureCloud": {
+        "southcentralus": ["ossdev", "osshf", "ossmc"],
+        "northcentralus": ["ossdev", "osshf", "ossmc"],
+        "osshf": {
+            "subscriptions": ["4a5d02ab-e0c3-4d39-8031-293ddd4e1875"],
+            "privateDnsZoneDomain": "pg.osshf-scus1-a.mscds.com"
+        },
+        "ossdev": {
+            "subscriptions": ["4a739919-f590-44f7-9eb8-0b84cde3bac8"],
+            "privateDnsZoneDomain": "pg.ossdev-scus1-a.mscds.com"
+        },
+        "ossmc": {
+            "subscriptions": ["d4fbfa87-b94d-4b13-906f-97361388c5e4"],
+            "privateDnsZoneDomain": "pg.ossmc-scus1-a.mscds.com"
+        }
+    },
+    "AzureChinaCloud": {
+    },
+    "AzureUSGovernment": {
+    },
+    "AzureGermanCloud": {
+    },
+    "Stage": {
+    }
+}

src/azure-cli/azure/cli/command_modules/rdbms/flexible_server_virtual_network.py

@@ -15,6 +15,7 @@
 from azure.mgmt.privatedns.models import SubResource
 from azure.mgmt.privatedns.models import VirtualNetworkLink
 from ._client_factory import resource_client_factory, private_dns_client_factory, private_dns_link_client_factory
+from ._config_reader import get_cloud_cluster
 from ._flexible_server_util import get_id_components, check_existence, _is_resource_name, parse_public_access_input, get_user_confirmation, _check_resource_group_existence
 from .validators import validate_private_dns_zone, validate_vnet_location
 
@@ -338,14 +339,6 @@ def prepare_mysql_exist_private_dns_zone(cmd, resource_group, private_dns_zone,
 
 def prepare_private_dns_zone(db_context, resource_group, server_name, private_dns_zone, subnet_id, location, yes):
     cmd = db_context.cmd
-    dns_suffix_client = db_context.cf_private_dns_zone_suffix(cmd.cli_ctx, '_')
-    private_dns_zone_suffix = dns_suffix_client.execute()
-    if db_context.command_group == 'mysql':
-        private_dns_zone_suffix = private_dns_zone_suffix.private_dns_zone_suffix
-
-    # suffix should start with .
-    if private_dns_zone_suffix[0] != '.':
-        private_dns_zone_suffix = '.' + private_dns_zone_suffix
 
     # Get Vnet Components
     vnet_subscription, vnet_rg, vnet_name, _ = get_id_components(subnet_id)
@@ -360,6 +353,20 @@ def prepare_private_dns_zone(db_context, resource_group, server_name, private_dn
         "resource_group": vnet_rg
     })
 
+    cluster = get_cloud_cluster(cmd, location.replace('/ +/g', '').lower(), vnet_subscription)
+
+    if cluster is not None:
+        private_dns_zone_suffix = cluster["privateDnsZoneDomain"]
+    else:
+        dns_suffix_client = db_context.cf_private_dns_zone_suffix(cmd.cli_ctx, '_')
+        private_dns_zone_suffix = dns_suffix_client.execute()
+        if db_context.command_group == 'mysql':
+            private_dns_zone_suffix = private_dns_zone_suffix.private_dns_zone_suffix
+
+    # suffix should start with .
+    if private_dns_zone_suffix[0] != '.':
+        private_dns_zone_suffix = '.' + private_dns_zone_suffix
+
     # Process private dns zone (no input or Id input)
     dns_rg = None
     dns_subscription = vnet_subscription