[AKS] az aks create/update: Update region map for default region creation with new Azure Monitor Workspace regions
#28236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Workspace regions
️✔️AzureCLI-FullTest
|
|
Hi @bragi92, |
️✔️AzureCLI-BreakingChangeTest
|
|
AKS |
microsoft-github-policy-service
bot
requested review from
yanzhudd,
yonzhan and
FumingZhang
microsoft-github-policy-service
bot
added
Auto-Assign
|
@zhoxing-ms , @FumingZhang please have a look at this PR whenever you have a chance. |
FumingZhang
reviewed
Feb 18, 2024
Merged
3 tasks
|
@FumingZhang I created another PR to fix the CRI issue here : https://github.com/Azure/azure-cli/pull/28414/files. Can you please approve and merge it in if it looks good? |
zhoxing-ms
approved these changes
Feb 21, 2024
FumingZhang
approved these changes
Feb 21, 2024
|
@FumingZhang or @zhoxing-ms can you help me with merging this PR in? I do not have write permissions to the repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks create -n kaveeshcli22 -g kaveeshcli --location westeurope --enable-azure-monitor-metrics --grafana-resource-id "{full_id}"az aks update -n kaveeshcli22 -g kaveeshcli --enable-azure-monitor-metrics --enable-windows-recording-rulesDescription
Azure Monitor Workspace now supports new regions so I am updating the default mapping for Azure Monitor Workspace to support these new regions in case the customer does not provide one while onboarding to the Managed Prometheus addon.
Testing Guide
Scenario (region map update):
az cloud set --name AzureCloudaz aks create -n kaveeshcli -g kaveeshcli --location canadaeast--enable-azure-monitor-metricsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.