{AKS} az aks update: delete uneeded disable_addons check in postprocessing_after_mc_created
#28414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cessing_after_mc_created
bragi92
requested review from
zhoxing-ms,
andyliuliming,
jsntcy and
yanzhudd
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @bragi92, |
️✔️AzureCLI-BreakingChangeTest
|
|
AKS |
microsoft-github-policy-service
bot
added
Auto-Assign
FumingZhang
reviewed
Feb 21, 2024
There was a problem hiding this comment.
lgtm
Queued live test to validate the change, test passed!
- test_aks_create_default_service_with_monitoring_addon
- test_aks_create_default_service_with_monitoring_addon_msi
- test_aks_update_to_msi_cluster_with_addons
- test_aks_create_with_monitoring_legacy_auth
- test_aks_create_with_monitoring_aad_auth_msi
- test_aks_create_with_monitoring_aad_auth_uai
- test_aks_create_with_monitoring_aad_auth_msi_with_syslog
- test_aks_create_with_monitoring_aad_auth_msi_with_datacollectionsettings
- test_aks_create_with_monitoring_aad_auth_uai_with_syslog
FumingZhang
approved these changes
Feb 21, 2024
zhoxing-ms
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az aks addon enable --addon monitoring -n kaveeshcli -g kaveeshcliaz aks addon disable --addon monitoring -n kaveeshcli -g kaveeshcliDescription
Removing this based on the comment on this PR: #28236 (review)
Testing Guide
az cloud set --name AzureCloudThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.