Feature/list component with checkboxes #2926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ippa/app-frontend-react into Feature/ListComponent
olemartinorg
added
the
kind/product-feature
olemartinorg
approved these changes
Jan 28, 2025
There was a problem hiding this comment.
Sorry for the long delay in reviewing this! 🫣 Overall, this looks very good! Thank you!! 🫶
There are a few things to consider when looking closely at the details (apart from the comments I wrote):
- When you uncheck a checkbox, the repeating group row will be deleted. If the user had put any more info in the repeatin group row, that info is now lost - this is what we made
AlertOnDeleteto warn the user against. Not a hard requirement for now, but something we might consider in the future. - Again, if you allow users to add more info in the repeating group row (which is not part of your use-case, but will be part of other use-cases), unchecking and then re-checking a checkbox will wipe extra data from the repeating group row. I hope to implement a solution for that, for example in Binde MultipleSelect/Checkboxes til en repeterende gruppe i datamodellen #1497.
(This is not something I expect you to fix, these are more like notes for myself for later!)
…T for data model bindings; simplify saveToList logic
…ippa/app-frontend-react into Feature/ListComponent
olemartinorg
merged commit 52ccc87
into
Altinn:feat/list-checkboxes
6 of 7 checks passed
|
I merged this into |
paal2707
added a commit
that referenced
this pull request
Feb 27, 2025
* Feature/list component with checkboxes (#2926) Co-authored-by: Johanne Lie <joli@patentstyret.no> Co-authored-by: adamhaeger <adamgullerud@gmail.com> * Remove errors and bugs * Allowing 'integer' as a number type, fixing type issues in data model path validator * Fix validation message and config * Cypress test for list with checkboxes and changes to support only mandatory for bound values * Fix better tests * Refactor and cleanup * Refactor and cleanup * Refactor and cleanup * Fix caption on listSummary * Fix caption on listSummary * Refactor for readability * Fix error with tests after refactoring * Fix error with tests after refactoring * Fix error with tests after refactoring * Refactor --------- Co-authored-by: Filippa Wallden <143729834+walldenfilippa@users.noreply.github.com> Co-authored-by: Johanne Lie <joli@patentstyret.no> Co-authored-by: adamhaeger <adamgullerud@gmail.com> Co-authored-by: Ole Martin Handeland <git@olemartin.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue(s)
Verification/QA
Manual functionality testing
Automated tests
UU/WCAG (follow these guidelines until we have our own)
User documentation @ altinn-studio-docs
Support in Altinn Studio
Sprint board
Labels
kind/*label to this PR for proper release notes grouping