Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/list checkboxes #3007

Merged
merged 19 commits into from
Feb 27, 2025
Merged

Feat/list checkboxes #3007

merged 19 commits into from
Feb 27, 2025

Conversation

paal2707
Copy link
Contributor

@paal2707 paal2707 commented Feb 13, 2025

Description

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

walldenfilippa and others added 5 commits February 6, 2025 11:30
Co-authored-by: Johanne Lie <joli@patentstyret.no>
Co-authored-by: adamhaeger <adamgullerud@gmail.com>
# Conflicts:
#	src/layout/List/ListComponent.tsx
@paal2707 paal2707 added the kind/product-feature Pull requests containing new features label Feb 13, 2025
@paal2707
Copy link
Contributor Author

/publish

Copy link
Contributor

github-actions bot commented Feb 13, 2025

PR release:

  • <link rel="stylesheet" type="text/css" href="https://altinncdn.no/toolkits/altinn-app-frontend/4.16.1-pr.535.list-checkboxes.38ca4c8b/altinn-app-frontend.css">
  • <script src="https://altinncdn.no/toolkits/altinn-app-frontend/4.16.1-pr.535.list-checkboxes.38ca4c8b/altinn-app-frontend.js"></script>

⚙️ Building...
✅ Done!

@paal2707 paal2707 marked this pull request as ready for review February 20, 2025 08:06
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Får det ikke helt til å funke. Krasjer både for selve komponenten og summary, så enten så gjør jeg noe feil og det må mer feilhåndtering/bedre feilmeldinger til eller så er det bugs 🤷‍♀️ Supert om du også får skrevet unit-tester 🙏

@paal2707 paal2707 requested a review from cammiida February 25, 2025 13:36
Copy link
Contributor

@cammiida cammiida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bra jobba! 🙌

summaryComponentId=''
/>
</div>
<Table>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det kan hende api-et heller burde wrappe de forskjellige table-komponentene som de er, men er fortsatt en fordel at alt får samme implementasjon 🤷‍♀️ og den støtter enkle caser og, blir bare noen få linjer med kode. Men du får bestemme!

<AppTable
  columns={Object.entries(tableHeaders).map(([key, value]) => ({
    header: <Lang id={value} />,
    accessors: [key],
  }))}
  size='md'
  data={displayRows}
  schema={{}}
/>

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.8% Coverage on New Code (required ≥ 45%)
14.17% Condition Coverage on New Code (required ≥ 45%)

See analysis details on SonarQube Cloud

@paal2707 paal2707 merged commit 23ecaec into main Feb 27, 2025
14 of 15 checks passed
@paal2707 paal2707 deleted the feat/list-checkboxes branch February 27, 2025 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/product-feature Pull requests containing new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants