-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/list checkboxes #3007
Feat/list checkboxes #3007
Conversation
Co-authored-by: Johanne Lie <joli@patentstyret.no> Co-authored-by: adamhaeger <adamgullerud@gmail.com>
# Conflicts: # src/layout/List/ListComponent.tsx
/publish |
PR release:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Får det ikke helt til å funke. Krasjer både for selve komponenten og summary, så enten så gjør jeg noe feil og det må mer feilhåndtering/bedre feilmeldinger til eller så er det bugs 🤷♀️ Supert om du også får skrevet unit-tester 🙏
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bra jobba! 🙌
summaryComponentId='' | ||
/> | ||
</div> | ||
<Table> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det kan hende api-et heller burde wrappe de forskjellige table-komponentene som de er, men er fortsatt en fordel at alt får samme implementasjon 🤷♀️ og den støtter enkle caser og, blir bare noen få linjer med kode. Men du får bestemme!
<AppTable
columns={Object.entries(tableHeaders).map(([key, value]) => ({
header: <Lang id={value} />,
accessors: [key],
}))}
size='md'
data={displayRows}
schema={{}}
/>
|
Description
Related Issue(s)
Verification/QA
kind/*
label to this PR for proper release notes grouping