fix: Helpers.swift: iOS application getting killed for using too much memory when creating temp file with range #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That makes sense - I don't think I expected a range (chunk size) that big! Why did you delete the lines with the size check? That's still relevant here, isn't it? |
|
You are right it is an overlook on my side of the generated code. I will rework the commit to make a more conservative approach. I should be able to send an update this morning after I tested it again. |
… file Uploading a large file (e.g. approx. 3GB), with the range header set, consummes too much memory resulting in app being killed by the task manager. This patch creates a temporary file using chunks of 1MB from the source file. This limits the overall memory consumption of such operation.
|
I edited the commit to keep the size check at the beginning, changed error message to be more informative, and edited the commit message to be more descriptive and fitting to the repository existing commit messages. I tested it and it works. |
|
Thanks much! Merged (with some additional simplification) in V8.9.3 |
This was referenced Feb 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On an iphone 12 Pro when trying to upload a file of 3GB:
contentLengthis3215658751for example: https://github.com/781flyingdutchman/background_downloader/blob/main/ios/background_downloader/Sources/background_downloader/Helpers.swift#L78If found with the help of ChatGPT this alternative method of creating a temp file that works for a big file and keeps the memory usage stable because we have a fixed chunk size for read and write operations.
Thanks, again for the awesome project.