Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: compilation failure without any async runtime #87

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

snejugal
Copy link

@snejugal snejugal commented Mar 6, 2025

cacache currently doesn't compile with both tokio and async-std disabled due to improper cfgs:

$ cargo c --no-default-features
    Checking cacache v13.1.0 (/home/snejugal/projects/cacache-rs)
error[E0412]: cannot find type `State` in this scope
   --> src/content/write.rs:430:37
    |
430 | fn update_state(current_state: &mut State, next_state: State) {
    |                                     ^^^^^ not found in this scope

error[E0412]: cannot find type `State` in this scope
   --> src/content/write.rs:430:56
    |
430 | fn update_state(current_state: &mut State, next_state: State) {
    |                                                        ^^^^^ not found in this scope

warning: unused import: `crate::Error`
  --> src/content/write.rs:22:5
   |
22 | use crate::Error;
   |     ^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default

For more information about this error, try `rustc --explain E0412`.
warning: `cacache` (lib) generated 1 warning
error: could not compile `cacache` (lib) due to 2 previous errors; 1 warning emitted

I guess it's worth testing this case in CI (since README shows how to use this crate sync-only), but I believe this belongs to a different PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant