Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zk.tag.list LSP error message #522

Merged
merged 1 commit into from
Feb 24, 2025
Merged

Conversation

mcDevnagh
Copy link
Member

zk list's error messages says zk.tag.list in the error message, when it should be zk list

Repro Steps

call the following lua code in neovim with the zk lsp attached:

require("zk.api").list("", {}, function(err, notes)
    vim.print(err)
end)

the following error message is printed:

{
  code = -32600,
  message = "zk.tag.list expects a `select` option with the list of fields to return",
  <metatable> = {
    __tostring = <function 1>
  }
}

@mcDevnagh mcDevnagh requested a review from tjex February 21, 2025 00:25
Copy link
Member

@tjex tjex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one. thanks :)

@tjex tjex merged commit f581447 into zk-org:main Feb 24, 2025
3 checks passed
@tjex tjex changed the title Fix LSP error message Fix zk.tag.list LSP error message Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants