ring 0.17.X upgrade #1318
Closed
ring 0.17.X upgrade #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AloeareV is this review ready? It is marked draft. |
Yes, this is review ready! It currently depends on a librustzcash version by commit hash instead of by tag, zingolabs/librustzcash#25 is the PR with the changed librustzcash. |
|
So maybe we should put this behind the LRZ upgrade? |
|
Let's deprioritze this behind the LRZ update. |
I don't know what you mean. The LRZ update is functional. |
If this PR is not necessary to support ZIP320 in mobile, then let's delay work on it. |
|
closing in favor of: #1457 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to build
Zingo-pcforwindows arm64I need to upgrade toring 0.17.xI need to upgrade
BIP0039from0.10.1to0.11.0or0.12.0inzcash_primitives(https://github.com/zingolabs/librustzcash.git?tag=always_require_change#ae0d477a).I don't have a clue if this can be a problem in
zingolib.@idky137 Can you help me with that, I hear you have a lot of experience with dependencies...