Value: ensure that extern structs have their layout resolved in ptrField #23165
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexrp
reviewed
Mar 10, 2025
| var callbacks: Callbacks = undefined; | ||
| var callbacks_loaded: bool = false; | ||
|
|
||
| test "function pointer field call on global extern struct, conditional on global" { |
There was a problem hiding this comment.
Suggested change
| test "function pointer field call on global extern struct, conditional on global" { | |
| test "function pointer field call on global extern struct, conditional on global" { | |
| if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest; |
alexrp
reviewed
Mar 10, 2025
| } | ||
| } | ||
|
|
||
| test "function pointer field call on global extern struct" { |
There was a problem hiding this comment.
Suggested change
| test "function pointer field call on global extern struct" { | |
| test "function pointer field call on global extern struct" { | |
| if (builtin.zig_backend == .stage2_spirv64) return error.SkipZigTest; |
There was a problem hiding this comment.
Aha, thanks! Fixed.
kcbanner
force-pushed
the
globally_conditional_global_extern_field_call
branch
from
1cb8017 to
6c46a9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23161.
Before this fix,
"function pointer field call on global extern struct, conditional on global"reproduces the above.This resolution feels like it should be conditional on something - since it seems to only be required when the call itself is conditional on a global - let me know if this resolution should be done elsewhere.