make @errorCast not pop error return traces #23136
Open
+27
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20177
This is my first time really going deeper into the compiler, so please
spare me if I made some fatal mistake. I decided to tackle this one
since I can across it while debugging a project of mine, and thought it
would be a good place to get a foot in the water of the compiler
internals.
The actual patch to the bug is one line, which leads to
AstGen.callExpr
having the proper value forpropagate_error_trace
.Additionally, I made
print_zir.writeCall
print thepop_error_return_trace
value of function calls to help futuredebugging.
As an extra goodie, I also refactored the type of
Zir.Flags.packed_modifier
to directly usestd.builtin.CallModifier
,removing all the messy casting. I did this since I saw the mess while
tracing down this bug.