-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix float vector comparisons with signed zero and NaN, add test coverage #21933
Conversation
I observed these failures on the CI, so I've disabled these new tests on these targets:
|
d34b378
to
8006052
Compare
8006052
to
cae5790
Compare
Rebased and force-pushed. The only missing consideration I see here has to do with comptime function call memoization. comptime call memoization should only occur if the float values are bit-for-bit equal, since floats have well-defined memory layout. I'm unsure whether this changeset respects that rule or not, and unsure whether there is already behavior test coverage for this or not. |
Breakage from changes in #22589: |
I'll update this PR this weekend - I'm not familiar with how to test for memoization behaviour but I assume there are existing tests I can reference for that. |
Sema: fix equality comparison of signed zeroes and NaN in compareScalar tests: add test coverage for vector float comparisons
cae5790
to
144d69b
Compare
Fixed up the breakage from #22589 and added comptime memoization tests. |
Thanks! |
Fix float vector comparisons with signed zero and NaN, add test coverage
Fix float vector comparisons with signed zero and NaN, add test coverage
Closes #21932