project: launch subprocesses without shell #783
Conversation
In the Project method set_new_manifest_rev, the _update_manifest_rev
helper function tries to run the following git command:
git update-ref -m .. refs/heads/ref <commit-id>^{commit}
However, on Msys2's MinGW build of python handles the escaping of
"...^{commit}" incorrectly, converting it into "...commit".
This issue highlights the pitfalls of using the Python subprocess
module's shell=True option, which can apply string conversions to
commands that are unexpected by the calling code.
Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
|
I agree If you don't have time for a complete fix, could you please turn this into a new bug? I could be wrong but I don't remember this being already filed. |
|
I misunderstood the problem hence why I closed the PR. I am experimenting with packaging West for MSys2 MINGW-packages, however there is an impedance mismatch between West built for MinGW Python (native Windows), and Git which is currently only available as the Cygwin/MSys2 version (simulated UNIX). The issues are explained in more detail here. The question is what to do about it. Installing Git4Windows into MSys2 MinGW is one possible solution. Another thought that crossed my mind was to replace invocation of the Git executable with a Python Git library e.g. pygit2 , but I don't know if there is a Python Git library that is capable of all the requirements of West e.g. rebasing. |
In the Project method
set_new_manifest_rev, the_update_manifest_revhelper function tries to run the following git command:However, on Msys2's MinGW build of python handles the escaping of
...^{commit}incorrectly, converting it into...commit.This issue highlights the pitfalls of using the Python
subprocessmodule'sshell=Trueoption, which can apply string conversions to commands that are unexpected by the calling code.