Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
project: launch subprocesses without shell
In the Project method set_new_manifest_rev, the _update_manifest_rev helper function tries to run the following git command: git update-ref -m .. refs/heads/ref <commit-id>^{commit} However, on Msys2's MinGW build of python handles the escaping of "...^{commit}" incorrectly, converting it into "...commit". This issue highlights the pitfalls of using the Python subprocess module's shell=True option, which can apply string conversions to commands that are unexpected by the calling code. Signed-off-by: Joel Holdsworth <jholdsworth@nvidia.com>
- Loading branch information