Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github workflows #1415

Merged
merged 1 commit into from
Feb 28, 2025
Merged

Fix github workflows #1415

merged 1 commit into from
Feb 28, 2025

Conversation

Chralt98
Copy link
Member

What does it do?

It fixes two issues that result in failing workflows.

What important points should reviewers know?

https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/

error: failed to compile `taplo-cli v0.8.1 (https://github.com/tamasfe/taplo?rev=848722f2c604de68535e5a3e0bb2a2c1d3c7dc74#848722f2)`, intermediate artifacts can be found at `/tmp/cargo-installSF7V0Q`.
To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

Caused by:
  rustc 1.79.0-nightly is not supported by the following packages:
    litemap@0.7.5 requires rustc 1.81
    zerofrom@0.1.6 requires rustc 1.81
  Either upgrade rustc or select compatible dependency versions with
  `cargo update <name>@<current-ver> --precise <compatible-ver>`
  where `<compatible-ver>` is the latest version supporting rustc 1.79.0-nightly
Running cargo formatting ...
OK
Running taplo formatting ...
./scripts/tests/format.sh: line 57: taplo: command not found
Error: Process completed with exit code 1.

Is there something left for follow-up PRs?

What alternative implementations were considered?

Are there relevant PRs or issues?

References

@Chralt98 Chralt98 added the s:review-needed The pull request requires reviews label Feb 28, 2025
@Chralt98 Chralt98 self-assigned this Feb 28, 2025
@Chralt98 Chralt98 added s:accepted This pull request is ready for merge and removed s:review-needed The pull request requires reviews labels Feb 28, 2025
@Chralt98 Chralt98 merged commit 13ef587 into main Feb 28, 2025
23 checks passed
@Chralt98 Chralt98 deleted the chralt98-fix-github-workflows branch February 28, 2025 08:13
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.47%. Comparing base (09ff686) to head (c280122).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1415   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files         183      183           
  Lines       34942    34942           
=======================================
  Hits        32662    32662           
  Misses       2280     2280           
Flag Coverage Δ
tests 93.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s:accepted This pull request is ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants