Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Orchard ZIP 32 test vectors #102

Merged
merged 3 commits into from
Oct 24, 2024
Merged

Add Orchard ZIP 32 test vectors #102

merged 3 commits into from
Oct 24, 2024

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Oct 1, 2024

No description provided.

@nuttycom
Copy link
Contributor

nuttycom commented Oct 1, 2024

Error in test vector generation:

✗ ./regenerate.sh rust rs
# orchard_zip32
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/nuttycom/work/zcash-test-vectors/zcash_test_vectors/orchard/zip32.py", line 69, in main
    m = DerivedSpendingKey.master(seed)
        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/nuttycom/work/zcash-test-vectors/zcash_test_vectors/orchard/zip32.py", line 28, in master
    return cls(ExtendedSpendingKey(S))
               ^^^^^^^^^^^^^^^^^^^^^^
TypeError: ExtendedSpendingKey.__init__() missing 1 required positional argument: 'data'

@str4d str4d force-pushed the orchard-zip32 branch 4 times, most recently from e9da65f to 3a4b155 Compare October 1, 2024 19:29
str4d and others added 3 commits October 2, 2024 16:32
@str4d
Add Orchard ZIP 32 test vectors
580dc95
@nuttycom @str4d
Modify the regenerate script to be more user-friendly.
346740a 
This now takes the generation type or 'all' as the first argument,
and then the generator or 'all' as the second argument. File extensions
are detemined automatically from the generation type.
@nuttycom @str4d
Generate test vectors for orchard_zip32
bff71ae
@str4d
Copy link
Contributor Author

str4d commented Oct 2, 2024

Force-pushed to fix a type in the generated Rust test vectors.

nuttycom
nuttycom approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 5b76d4b into master Oct 24, 2024
3 checks passed
@nuttycom nuttycom deleted the orchard-zip32 branch October 24, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nuttycom nuttycom nuttycom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@str4d @nuttycom