Add commands to shield funds #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
requested changes
Dec 14, 2024
src/commands/shield.rs
Outdated
Comment on lines
70
to
73
| let account_id = *db_data | ||
| .get_account_ids()? | ||
| .first() | ||
| .ok_or(anyhow!("Wallet has no accounts"))?; |
There was a problem hiding this comment.
The account to use should be an optional CLI argument; this should only be a default & the default should only be allowed when there is only one account in the wallet.
src/commands/shield.rs
Outdated
| let derivation = account | ||
| .source() | ||
| .key_derivation() | ||
| .ok_or(anyhow!("Cannot spend from view-only accounts"))?; |
There was a problem hiding this comment.
Suggested change
| .ok_or(anyhow!("Cannot spend from view-only accounts"))?; | |
| .ok_or(anyhow!("Cannot spend from view-only accounts; did you mean to use `pczt shield` instead?"))?; |
nuttycom
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.