Add pczt inspect command
#63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuttycom
approved these changes
Dec 14, 2024
src/commands/pczt/inspect.rs
Outdated
| for (index, value) in sapling_outputs.iter().enumerate() { | ||
| if let Some(value) = value { | ||
| if value.inner() == 0 { | ||
| println!(" - Dummy Output"); |
There was a problem hiding this comment.
We shouldn't be using zero values on the output side to identify things as "dummies"; zero-valued outputs are valid and they may have a memo attached. We should also make sure that this isn't being done in the firmware.
src/commands/pczt/inspect.rs
Outdated
| } | ||
| if let Some(value) = output_value { | ||
| if value.inner() == 0 { | ||
| println!(" - Dummy Output"); |
There was a problem hiding this comment.
Ditto; we should probably have a way to specifically mark the dummies in the PCZT.
nuttycom
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.