Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix beta Clippy complaints about rustdoc formatting. #1719

Merged
merged 3 commits into from
Feb 27, 2025
Merged

Conversation

nuttycom
Copy link
Contributor

No description provided.

daira
daira previously approved these changes Feb 26, 2025
Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK modulo a typo.

@daira
Copy link
Contributor

daira commented Feb 26, 2025

$ cargo +beta clippy
[...]
warning: manually reimplementing `is_power_of_two`
  --> zcash_history/src/entry.rs:35:9
   |
35 |         leaves & (leaves - 1) == 0
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.is_power_of_two()`: `leaves.is_power_of_two()`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_power_of_two
   = note: `#[warn(clippy::manual_is_power_of_two)]` on by default

warning: `zcash_history` (lib) generated 1 warning (run `cargo clippy --fix --lib -p zcash_history` to apply 1 suggestion)

Copy link

codecov bot commented Feb 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (3ea34e8) to head (c947540).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1719      +/-   ##
==========================================
- Coverage   54.15%   54.15%   -0.01%     
==========================================
  Files         176      176              
  Lines       20476    20475       -1     
==========================================
- Hits        11089    11088       -1     
  Misses       9387     9387              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom merged commit 90d186f into main Feb 27, 2025
34 of 35 checks passed
@nuttycom nuttycom deleted the fix_beta_lints branch February 27, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants