zcash_protocol: Add constants for the NU7 Network Upgrade #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
==========================================
- Coverage 54.15% 54.12% -0.03%
==========================================
Files 176 176
Lines 20475 20486 +11
==========================================
Hits 11088 11088
- Misses 9387 9398 +11 ☔ View full report in Codecov by Sentry. |
nuttycom
force-pushed
the
nu7_constants
branch
from
74336ba to
d348681
Compare
This eliminates duplication of these constants in the `pczt` module. It introduces a non-optional dependency of `pczt` on `zcash_protocol`, but as the `pczt` crate is almost not meaningfully useful without the `zcash_protocol` dependency anyway, and `zcash_protocol` is very lightweight, this is an acceptable tradeoff.
Access to the newly-added constants is guarded behind the `zcash_unstable = "nu7"` config flag.
nuttycom
force-pushed
the
nu7_constants
branch
from
d348681 to
0f00e24
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.