Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avert MSRV breakage in WASM & no-std builds. #1717

Merged
merged 2 commits into from
Feb 26, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ jobs:
# We use a synthetic crate to ensure no dev-dependencies are enabled, which can
# be incompatible with some of these targets.
- name: Create synthetic crate for testing
run: cargo init --lib ci-build
run: cargo init --lib ci-build --edition 2021
- name: Copy Rust version into synthetic crate
run: cp crates/rust-toolchain.toml ci-build/
- name: Copy patch directives into synthetic crate
Expand Down Expand Up @@ -316,7 +316,7 @@ jobs:
# We use a synthetic crate to ensure no dev-dependencies are enabled, which can
# be incompatible with some of these targets.
- name: Create synthetic crate for testing
run: cargo init --lib ci-build
run: cargo init --lib ci-build --edition 2021
- name: Copy Rust version into synthetic crate
run: cp crates/rust-toolchain.toml ci-build/
- name: Copy patch directives into synthetic crate
Expand Down
2 changes: 2 additions & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ pasta_curves = "0.5"

# - Transparent
bip32 = { version = "=0.6.0-pre.1", default-features = false }
block-buffer = { version = "=0.11.0-rc.3" } # later RCs require edition2024
crypto-common = { version = "=0.2.0-rc.1" } # later RCs require edition2024
ripemd = { version = "0.1", default-features = false }
secp256k1 = { version = "0.29", default-features = false, features = ["alloc"] }
transparent = { package = "zcash_transparent", version = "0.2", path = "zcash_transparent", default-features = false }
Expand Down
2 changes: 2 additions & 0 deletions zcash_primitives/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ transparent.workspace = true
# - Transparent inputs
# - `Error` type exposed
bip32.workspace = true
block-buffer.workspace = true # remove after edition2024 upgrade
crypto-common.workspace = true # remove after edition2024 upgrade
# - `SecretKey` and `PublicKey` types exposed
secp256k1 = { workspace = true, optional = true }

Expand Down
Loading