[YDS-#248] Improve : SingleTopBar, DoubleTopBar 네비게이션 아이콘 넣을 수 있게 #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cometj03
reviewed
Feb 3, 2024
| navigationIcon = { | ||
| TopBarButton( | ||
| icon = R.drawable.ic_arrow_left_line, | ||
| isDisabled = false, |
There was a problem hiding this comment.
isDisabled = false는 이제 없어도 되지 않나요?
There was a problem hiding this comment.
예전 disabled가 true가 기본값이었을때가 있는데 그 유산이네요...
|
넹 |
cometj03
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
기존 SingleTitleTopBar, DoubleTitleTopBar에 네비게이션 아이콘을 넣을 수 없었어서 수정함
Describe your changes
Issue
#248
To reviewers