Improve tests #6
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added separate tests for `.add()` * added tests for adding/removing multiple classes * all HTML tests now have SVG variants for better coverage * clarified test titles for `.toggle()` as to differentiate them from the other methods * switched to current latest 2.x version of QUnit
|
Not yet willing to give up on upstream: eligrey#63 |
|
I've rewritten all the tests and implemented e2e scaffolding and a bit of CI so the polyfill gets tested across browsers. Closing this in favor of: eligrey#69 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.add().toggle()as to differentiate them from the other methods