Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(URL): Share link with search parameters #173

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
10656aa
Add share link with search parameters button, update url search param…
Henry8192 Jan 20, 2025
ae155bf
Amend of previous commit
Henry8192 Jan 20, 2025
6647961
snapshot
Henry8192 Jan 25, 2025
d398cee
copy link with search parameters works
Henry8192 Jan 27, 2025
d4398aa
Merge branch 'main' into share-link-with-search-params
Henry8192 Jan 30, 2025
7761079
fix most lint errors except one useEffect dependency warning
Henry8192 Feb 1, 2025
7d446bd
remove isFileLoaded and move position of startQuery definition
Henry8192 Feb 4, 2025
a8224ba
Merge branch 'main' into share-link-with-search-params
Henry8192 Feb 4, 2025
c4aa866
rename query parameter names and make them as hash parameters
Henry8192 Feb 20, 2025
a2a9b2c
Creates a useEffect that starts new queries and clear query parameter…
Henry8192 Feb 20, 2025
dd88ba3
Merge branch 'main' into share-link-with-search-params
Henry8192 Feb 24, 2025
6d43037
fix lint
Henry8192 Feb 24, 2025
12dd17e
Merge branch 'main' into share-link-with-search-params
Henry8192 Feb 26, 2025
5d45031
url hash query works, but it doesn't sync query options to SearchBarTabs
Henry8192 Feb 26, 2025
cb62201
Merge branch 'main' into share-link-with-search-params
Henry8192 Feb 26, 2025
c6b97a9
sync query options to SearchBarTabs; clear #logEventNum from share li…
Henry8192 Feb 27, 2025
c6237ab
fix dependency warnings
Henry8192 Feb 27, 2025
7dd50b9
Merge branch 'main' into share-link-with-search-params
Henry8192 Feb 27, 2025
99db24d
clear query parameters from input box when loading another file
Henry8192 Feb 28, 2025
691a911
startQuery should first check the corner case before incrementing que…
Henry8192 Feb 28, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, {
useContext,
useEffect,
useState,
} from "react";

Expand All @@ -11,19 +12,30 @@
Textarea,
} from "@mui/joy";

import ShareIcon from "@mui/icons-material/Share";
import UnfoldLessIcon from "@mui/icons-material/UnfoldLess";
import UnfoldMoreIcon from "@mui/icons-material/UnfoldMore";

import {StateContext} from "../../../../../contexts/StateContextProvider";
import {
copyPermalinkToClipboard,
updateWindowUrlHashParams,
URL_HASH_PARAMS_DEFAULT,
UrlContext,
} from "../../../../../contexts/UrlContextProvider";
import {
QUERY_PROGRESS_VALUE_MAX,
QueryArgs,
} from "../../../../../typings/query";
import {UI_ELEMENT} from "../../../../../typings/states";
import {
UI_ELEMENT,
UI_STATE,
} from "../../../../../typings/states";
import {
TAB_DISPLAY_NAMES,
TAB_NAME,
} from "../../../../../typings/tab";
import {HASH_PARAM_NAMES} from "../../../../../typings/url";
import {isDisabled} from "../../../../../utils/states";
import CustomTabPanel from "../CustomTabPanel";
import PanelTitleButton from "../PanelTitleButton";
Expand All @@ -38,21 +50,60 @@
*
* @return
*/
// eslint-disable-next-line max-lines-per-function
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// eslint-disable-next-line max-lines-per-function

We should avoid disabling linting rules whenever possible. Please see if the refactoring PR at #196 properly addresses this violation.

const SearchTabPanel = () => {
const {queryProgress, queryResults, startQuery, uiState} = useContext(StateContext);
const {
queryString: urlQueryString,
queryIsCaseSensitive: urlQueryIsCaseSensitive,
queryIsRegex: urlQueryIsRegex,
} = useContext(UrlContext);
const [isAllExpanded, setIsAllExpanded] = useState<boolean>(true);
const [queryString, setQueryString] = useState<string>("");
const [isCaseSensitive, setIsCaseSensitive] = useState<boolean>(false);
const [isRegex, setIsRegex] = useState<boolean>(false);
const [queryIsCaseSensitive, setQueryIsCaseSensitive] = useState<boolean>(false);
const [queryIsRegex, setQueryIsRegex] = useState<boolean>(false);

useEffect(() => {
if (uiState === UI_STATE.READY) {
if (null !== urlQueryString) {
setQueryString(urlQueryString);
setQueryIsCaseSensitive(urlQueryIsCaseSensitive ?? false);
setQueryIsRegex(urlQueryIsRegex ?? false);

startQuery({
queryIsCaseSensitive: urlQueryIsCaseSensitive ?? false,
queryIsRegex: urlQueryIsRegex ?? false,
queryString: urlQueryString,
});

updateWindowUrlHashParams({
[HASH_PARAM_NAMES.QUERY_STRING]: URL_HASH_PARAMS_DEFAULT.queryString,
[HASH_PARAM_NAMES.QUERY_IS_CASE_SENSITIVE]: URL_HASH_PARAMS_DEFAULT.queryIsCaseSensitive,

Check failure on line 81 in src/components/CentralContainer/Sidebar/SidebarTabs/SearchTabPanel/index.tsx

View workflow job for this annotation

GitHub Actions / lint-check

This line has a length of 109. Maximum allowed is 100
[HASH_PARAM_NAMES.QUERY_IS_REGEX]: URL_HASH_PARAMS_DEFAULT.queryIsRegex,
});
}
}
}, [

Check failure on line 86 in src/components/CentralContainer/Sidebar/SidebarTabs/SearchTabPanel/index.tsx

View workflow job for this annotation

GitHub Actions / lint-check

React Hook useEffect has missing dependencies: 'startQuery', 'urlQueryIsCaseSensitive', and 'urlQueryIsRegex'. Either include them or remove the dependency array
uiState,
urlQueryString,
]);

const handleCollapseAllButtonClick = () => {
setIsAllExpanded((v) => !v);
};
const handleShareButtonClick = () => {
copyPermalinkToClipboard({}, {
logEventNum: null,
queryString: queryString,
queryIsCaseSensitive: queryIsCaseSensitive,
queryIsRegex: queryIsRegex,
});
};

const handleQuerySubmit = (newArgs: Partial<QueryArgs>) => {
startQuery({
isCaseSensitive: isCaseSensitive,
isRegex: isRegex,
queryIsCaseSensitive: queryIsCaseSensitive,
queryIsRegex: queryIsRegex,
queryString: queryString,
...newArgs,
});
Expand All @@ -64,13 +115,13 @@
};

const handleCaseSensitivityButtonClick = () => {
handleQuerySubmit({isCaseSensitive: !isCaseSensitive});
setIsCaseSensitive(!isCaseSensitive);
handleQuerySubmit({queryIsCaseSensitive: !queryIsCaseSensitive});
setQueryIsCaseSensitive(!queryIsCaseSensitive);
};

const handleRegexButtonClick = () => {
handleQuerySubmit({isRegex: !isRegex});
setIsRegex(!isRegex);
handleQuerySubmit({queryIsRegex: !queryIsRegex});
setQueryIsRegex(!queryIsRegex);
};

const isQueryInputBoxDisabled = isDisabled(uiState, UI_ELEMENT.QUERY_INPUT_BOX);
Expand All @@ -80,16 +131,24 @@
tabName={TAB_NAME.SEARCH}
title={TAB_DISPLAY_NAMES[TAB_NAME.SEARCH]}
titleButtons={
<PanelTitleButton
title={isAllExpanded ?
"Collapse all" :
"Expand all"}
onClick={handleCollapseAllButtonClick}
>
{isAllExpanded ?
<UnfoldLessIcon/> :
<UnfoldMoreIcon/>}
</PanelTitleButton>
<>
<PanelTitleButton
title={isAllExpanded ?
"Collapse all" :
"Expand all"}
onClick={handleCollapseAllButtonClick}
>
{isAllExpanded ?
<UnfoldLessIcon/> :
<UnfoldMoreIcon/>}
</PanelTitleButton>
<PanelTitleButton
title={"Copy URL with search parameters"}
onClick={handleShareButtonClick}
>
<ShareIcon/>
</PanelTitleButton>
</>
}
>
<Box className={"search-tab-container"}>
Expand All @@ -99,6 +158,7 @@
maxRows={7}
placeholder={"Search"}
size={"sm"}
value={queryString}
endDecorator={
<Stack
direction={"row"}
Expand All @@ -107,7 +167,7 @@
<ToggleIconButton
className={"query-option-button"}
disabled={isQueryInputBoxDisabled}
isChecked={isCaseSensitive}
isChecked={queryIsCaseSensitive}
size={"sm"}
tooltipTitle={"Match case"}
variant={"plain"}
Expand All @@ -119,7 +179,7 @@
<ToggleIconButton
className={"query-option-button"}
disabled={isQueryInputBoxDisabled}
isChecked={isRegex}
isChecked={queryIsRegex}
size={"sm"}
tooltipTitle={"Use regular expression"}
variant={"plain"}
Expand Down
35 changes: 22 additions & 13 deletions src/contexts/StateContextProvider.tsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
/* eslint max-lines: ["error", 600] */
/* eslint max-lines: ["error", 650] */
import React, {
createContext,
useCallback,
Expand Down Expand Up @@ -247,14 +247,17 @@ const updateUrlIfEventOnPage = (
// eslint-disable-next-line max-lines-per-function, max-statements
const StateContextProvider = ({children}: StateContextProviderProps) => {
const {postPopUp} = useContext(NotificationContext);
const {filePath, logEventNum} = useContext(UrlContext);
const {
filePath,
logEventNum,
} = useContext(UrlContext);

// States
const [exportProgress, setExportProgress] =
useState<Nullable<number>>(STATE_DEFAULT.exportProgress);
const [fileName, setFileName] = useState<string>(STATE_DEFAULT.fileName);
const [isSettingsModalOpen, setIsSettingsModalOpen] =
useState<boolean>(STATE_DEFAULT.isSettingsModalOpen);
const [fileName, setFileName] = useState<string>(STATE_DEFAULT.fileName);
const [logData, setLogData] = useState<string>(STATE_DEFAULT.logData);
const [numEvents, setNumEvents] = useState<number>(STATE_DEFAULT.numEvents);
const [numPages, setNumPages] = useState<number>(STATE_DEFAULT.numPages);
Expand All @@ -276,6 +279,20 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
const pageNumRef = useRef<number>(pageNum);
const uiStateRef = useRef<UI_STATE>(uiState);

const startQuery = useCallback((queryArgs: {
queryString: string;
queryIsCaseSensitive: boolean;
queryIsRegex: boolean;
}) => {
setQueryResults(STATE_DEFAULT.queryResults);
if (null === mainWorkerRef.current) {
console.error("Unexpected null mainWorkerRef.current");

return;
}
workerPostReq(mainWorkerRef.current, WORKER_REQ_CODE.START_QUERY, queryArgs);
}, []);

const handleMainWorkerResp = useCallback((ev: MessageEvent<MainWorkerRespMessage>) => {
const {code, args} = ev.data;
console.log(`[MainWorker -> Renderer] code=${code}`);
Expand Down Expand Up @@ -368,16 +385,6 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
}
}, [postPopUp]);

const startQuery = useCallback((queryArgs: QueryArgs) => {
setQueryResults(STATE_DEFAULT.queryResults);
if (null === mainWorkerRef.current) {
console.error("Unexpected null mainWorkerRef.current");

return;
}
workerPostReq(mainWorkerRef.current, WORKER_REQ_CODE.START_QUERY, queryArgs);
}, []);

const exportLogs = useCallback(() => {
if (null === mainWorkerRef.current) {
console.error("Unexpected null mainWorkerRef.current");
Expand Down Expand Up @@ -406,6 +413,8 @@ const StateContextProvider = ({children}: StateContextProviderProps) => {
setLogData("Loading...");
setOnDiskFileSizeInBytes(STATE_DEFAULT.onDiskFileSizeInBytes);
setExportProgress(STATE_DEFAULT.exportProgress);
setQueryResults(STATE_DEFAULT.queryResults);
setQueryProgress(QUERY_PROGRESS_VALUE_MIN);

// Cache `fileSrc` for reloads.
fileSrcRef.current = fileSrc;
Expand Down
24 changes: 23 additions & 1 deletion src/contexts/UrlContextProvider.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ const URL_SEARCH_PARAMS_DEFAULT = Object.freeze({
*/
const URL_HASH_PARAMS_DEFAULT = Object.freeze({
[HASH_PARAM_NAMES.LOG_EVENT_NUM]: null,
[HASH_PARAM_NAMES.QUERY_IS_CASE_SENSITIVE]: false,
[HASH_PARAM_NAMES.QUERY_IS_REGEX]: false,
[HASH_PARAM_NAMES.QUERY_STRING]: null,
});

/**
Expand Down Expand Up @@ -101,7 +104,7 @@ const getUpdatedSearchParams = (updates: UrlSearchParamUpdatesType) => {
const getUpdatedHashParams = (updates: UrlHashParamUpdatesType) => {
const newHashParams = new URLSearchParams(window.location.hash.substring(1));
for (const [key, value] of Object.entries(updates)) {
if (null === value) {
if (null === value || false === value) {
newHashParams.delete(key);
} else {
newHashParams.set(key, String(value));
Expand Down Expand Up @@ -181,6 +184,10 @@ const getWindowUrlSearchParams = () => {
);
const urlSearchParams = new URLSearchParams(window.location.search.substring(1));

urlSearchParams.forEach((value, key) => {
searchParams[key as keyof UrlSearchParams] = value;
});

if (urlSearchParams.has(SEARCH_PARAM_NAMES.FILE_PATH)) {
// Split the search string and take everything after as `filePath` value.
// This ensures any parameters following `filePath=` are incorporated into the `filePath`.
Expand Down Expand Up @@ -211,6 +218,21 @@ const getWindowUrlHashParams = () => {
null :
parsed;
}
const queryString = hashParams.get(HASH_PARAM_NAMES.QUERY_STRING);
if (null !== queryString) {
urlHashParams[HASH_PARAM_NAMES.QUERY_STRING] = queryString;
}

const isCaseSensitive = hashParams.get(HASH_PARAM_NAMES.QUERY_IS_CASE_SENSITIVE);
if (null !== isCaseSensitive) {
urlHashParams[HASH_PARAM_NAMES.QUERY_IS_CASE_SENSITIVE] =
"true" === isCaseSensitive.toLowerCase();
}

const isRegex = hashParams.get(HASH_PARAM_NAMES.QUERY_IS_REGEX);
if (null !== isRegex) {
urlHashParams[HASH_PARAM_NAMES.QUERY_IS_REGEX] = "true" === isRegex.toLowerCase();
}

return urlHashParams;
};
Expand Down
10 changes: 5 additions & 5 deletions src/services/LogFileManager/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -291,11 +291,11 @@ class LogFileManager {
*
* @param queryArgs
* @param queryArgs.queryString
* @param queryArgs.isRegex
* @param queryArgs.isCaseSensitive
* @param queryArgs.queryIsRegex
* @param queryArgs.queryIsCaseSensitive
* @throws {SyntaxError} if the query regex string is invalid.
*/
startQuery ({queryString, isRegex, isCaseSensitive}: QueryArgs): void {
startQuery ({queryString, queryIsRegex, queryIsCaseSensitive}: QueryArgs): void {
this.#queryId++;
this.#queryCount = 0;

Expand All @@ -309,10 +309,10 @@ class LogFileManager {
}

// Construct query RegExp
const regexPattern = isRegex ?
const regexPattern = queryIsRegex ?
queryString :
queryString.replace(/[.*+?^${}()|[\]\\]/g, "\\$&");
const regexFlags = isCaseSensitive ?
const regexFlags = queryIsCaseSensitive ?
"" :
"i";

Expand Down
4 changes: 2 additions & 2 deletions src/typings/query.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
interface QueryArgs {
queryString: string;
isCaseSensitive: boolean;
isRegex: boolean;
queryIsCaseSensitive: boolean;
queryIsRegex: boolean;
}

type TextRange = [number, number];
Expand Down
9 changes: 8 additions & 1 deletion src/typings/url.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,14 +7,21 @@ enum SEARCH_PARAM_NAMES {

enum HASH_PARAM_NAMES {
LOG_EVENT_NUM = "logEventNum",
QUERY_IS_CASE_SENSITIVE = "queryIsCaseSensitive",
QUERY_IS_REGEX = "queryIsRegex",
QUERY_STRING = "queryString",
}

interface UrlSearchParams {
[SEARCH_PARAM_NAMES.FILE_PATH]: string;

}

interface UrlHashParams {
logEventNum: number;
[HASH_PARAM_NAMES.LOG_EVENT_NUM]: number;
[HASH_PARAM_NAMES.QUERY_IS_CASE_SENSITIVE]: boolean;
[HASH_PARAM_NAMES.QUERY_IS_REGEX]: boolean;
[HASH_PARAM_NAMES.QUERY_STRING]: string;
}

type UrlSearchParamUpdatesType = {
Expand Down
4 changes: 2 additions & 2 deletions src/typings/worker.ts
Original file line number Diff line number Diff line change
Expand Up @@ -112,8 +112,8 @@ type WorkerReqMap = {
};
[WORKER_REQ_CODE.START_QUERY]: {
queryString: string;
isRegex: boolean;
isCaseSensitive: boolean;
queryIsCaseSensitive: boolean;
queryIsRegex: boolean;
};
};

Expand Down
Loading