-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(URL): Share link with search parameters #173
Open
Henry8192
wants to merge
20
commits into
y-scope:main
Choose a base branch
from
Henry8192:share-link-with-search-params
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
10656aa
Add share link with search parameters button, update url search param…
Henry8192 ae155bf
Amend of previous commit
Henry8192 6647961
snapshot
Henry8192 d398cee
copy link with search parameters works
Henry8192 d4398aa
Merge branch 'main' into share-link-with-search-params
Henry8192 7761079
fix most lint errors except one useEffect dependency warning
Henry8192 7d446bd
remove isFileLoaded and move position of startQuery definition
Henry8192 a8224ba
Merge branch 'main' into share-link-with-search-params
Henry8192 c4aa866
rename query parameter names and make them as hash parameters
Henry8192 a2a9b2c
Creates a useEffect that starts new queries and clear query parameter…
Henry8192 dd88ba3
Merge branch 'main' into share-link-with-search-params
Henry8192 6d43037
fix lint
Henry8192 12dd17e
Merge branch 'main' into share-link-with-search-params
Henry8192 5d45031
url hash query works, but it doesn't sync query options to SearchBarTabs
Henry8192 cb62201
Merge branch 'main' into share-link-with-search-params
Henry8192 c6b97a9
sync query options to SearchBarTabs; clear #logEventNum from share li…
Henry8192 c6237ab
fix dependency warnings
Henry8192 7dd50b9
Merge branch 'main' into share-link-with-search-params
Henry8192 99db24d
clear query parameters from input box when loading another file
Henry8192 691a911
startQuery should first check the corner case before incrementing que…
Henry8192 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid disabling linting rules whenever possible. Please see if the refactoring PR at #196 properly addresses this violation.