Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): Restart log queries when case-sensitivity or regex button is toggled. #130

Merged
merged 12 commits into from
Dec 9, 2024
Merged

fix(query): Restart log queries when case-sensitivity or regex button is toggled. #130

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
ed2d79a
fix queryOptionButtons not restarting a search
Henry8192 Nov 25, 2024
698dd28
refactor according to code review
Henry8192 Dec 2, 2024
f7e3698
Merge branch 'main' into queryOptionButton-fix
Henry8192 Dec 3, 2024
01abd28
Merge branch 'main' into queryOptionButton-fix
Henry8192 Dec 3, 2024
31d9609
Update src/contexts/StateContextProvider.tsx
Henry8192 Dec 5, 2024
1bad3cc
refactor query related to `src/typings/query.ts`, change startQuery i…
Henry8192 Dec 5, 2024
c592b58
Merge branch 'main' into queryOptionButton-fix
Henry8192 Dec 5, 2024
6b50912
fix import issue
Henry8192 Dec 5, 2024
332b269
Apply suggestions from code review
Henry8192 Dec 9, 2024
139c7c3
throws error in front end if the query regex string is not valid
Henry8192 Dec 9, 2024
05a3219
amend error type
Henry8192 Dec 9, 2024
db5e700
Update src/typings/query.ts
Henry8192 Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions src/components/CentralContainer/Sidebar/SidebarTabs/SearchTabPanel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import React, {
useContext,
useRef,
useState,
} from "react";

Expand Down Expand Up @@ -44,8 +45,10 @@ const SearchTabPanel = () => {
const {queryProgress, queryResults, startQuery, uiState} = useContext(StateContext);
const [isAllExpanded, setIsAllExpanded] = useState<boolean>(true);
const [queryOptions, setQueryOptions] = useState<QUERY_OPTION[]>([]);
const queryStringRef = useRef<string>("");

const handleQueryInputChange = (ev: React.ChangeEvent<HTMLTextAreaElement>) => {
queryStringRef.current = ev.target.value;
const isCaseSensitive = queryOptions.includes(QUERY_OPTION.IS_CASE_SENSITIVE);
const isRegex = queryOptions.includes(QUERY_OPTION.IS_REGEX);
startQuery(ev.target.value, isRegex, isCaseSensitive);
Expand All @@ -55,6 +58,11 @@ const SearchTabPanel = () => {
newOptions: QUERY_OPTION[]
) => {
setQueryOptions(newOptions);
if ("" !== queryStringRef.current) {
const isCaseSensitive = newOptions.includes(QUERY_OPTION.IS_CASE_SENSITIVE);
const isRegex = newOptions.includes(QUERY_OPTION.IS_REGEX);
startQuery(queryStringRef.current, isRegex, isCaseSensitive);
}
};

return (
Expand Down