Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: Add support for hierarchical and auto-generated keys for log filtering. #62
feat!: Add support for hierarchical and auto-generated keys for log filtering. #62
Changes from all commits
bcd3b69
872b69d
dd923c9
a6b70c5
bbf7340
165a890
4618e0c
2a02ff8
483079a
4dc0ab8
9d5395e
62d83bd
4555da7
d5de853
2093972
65837c9
b8c9cf6
f12cf04
f46af70
c364896
03bd5b9
c0120ec
973966d
15211e2
eff990b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For ease of debugging -
can we print a log in deserialize_stream() after all IR units are decoded: if the
m_optional_log_level_full_branch
has value butm_optional_log_level_node_id
is not populated, warn the user that the node cannot be found. Similarly for the timestamp we should also warn the user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done