feat!: Remove timestamp formatting from unstructured log messages. (#61)

y-scope · Feb 22, 2025 · ee8ac2e · ee8ac2e
1 parent 35c754f
commit ee8ac2e
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 11 deletions.
diff --git a/src/clp_ffi_js/ir/UnstructuredIrStreamReader.cpp b/src/clp_ffi_js/ir/UnstructuredIrStreamReader.cpp
@@ -133,7 +133,6 @@ auto UnstructuredIrStreamReader::deserialize_stream() -> size_t {
 auto UnstructuredIrStreamReader::decode_range(size_t begin_idx, size_t end_idx, bool use_filter)
         const -> DecodedResultsTsType {
     auto log_event_to_string = [this](UnstructuredLogEvent const& log_event) -> std::string {
-        std::string message;
         auto const parsed{log_event.get_message().decode_and_unparse()};
         if (false == parsed.has_value()) {
             throw ClpFfiJsException{
@@ -143,9 +142,7 @@ auto UnstructuredIrStreamReader::decode_range(size_t begin_idx, size_t end_idx,
                     "Failed to decode message"
             };
         }
-        message = parsed.value();
-        m_ts_pattern.insert_formatted_timestamp(log_event.get_timestamp(), message);
-        return message;
+        return parsed.value();
     };
 
     return generic_decode_range(
@@ -167,10 +164,10 @@ auto UnstructuredIrStreamReader::find_nearest_log_event_by_timestamp(
 UnstructuredIrStreamReader::UnstructuredIrStreamReader(
         StreamReaderDataContext<UnstructuredIrDeserializer>&& stream_reader_data_context
 )
-        : m_stream_reader_data_context{std::make_unique<
-                  StreamReaderDataContext<UnstructuredIrDeserializer>>(
-                  std::move(stream_reader_data_context)
-          )},
-          m_ts_pattern{m_stream_reader_data_context->get_deserializer().get_timestamp_pattern()} {}
+        : m_stream_reader_data_context{
+                  std::make_unique<StreamReaderDataContext<UnstructuredIrDeserializer>>(
+                          std::move(stream_reader_data_context)
+                  )
+          } {}
 
 }  // namespace clp_ffi_js::ir
diff --git a/src/clp_ffi_js/ir/UnstructuredIrStreamReader.hpp b/src/clp_ffi_js/ir/UnstructuredIrStreamReader.hpp
@@ -7,7 +7,6 @@
 
 #include <clp/ir/LogEventDeserializer.hpp>
 #include <clp/ir/types.hpp>
-#include <clp/TimestampPattern.hpp>
 #include <emscripten/val.h>
 
 #include <clp_ffi_js/ir/LogEventWithFilterData.hpp>
@@ -85,7 +84,6 @@ class UnstructuredIrStreamReader : public StreamReader {
     std::unique_ptr<StreamReaderDataContext<UnstructuredIrDeserializer>>
             m_stream_reader_data_context;
     FilteredLogEventsMap m_filtered_log_event_map;
-    clp::TimestampPattern m_ts_pattern;
 };
 }  // namespace clp_ffi_js::ir