CRISTAL-471: Blocknote integration POC #712
Conversation
| @@ -62,6 +62,9 @@ export class DefaultWikiConfig implements WikiConfig { | |||
| public designSystem: string; | |||
| // @ts-expect-error offline is temporarily undefined during class | |||
There was a problem hiding this comment.
| // @ts-expect-error offline is temporarily undefined during class | |
| // @ts-expect-error editor is temporarily undefined during class |
| # Logs | ||
| logs | ||
| *.log | ||
| npm-debug.log* | ||
| yarn-debug.log* | ||
| yarn-error.log* | ||
| pnpm-debug.log* | ||
| lerna-debug.log* | ||
|
|
||
| node_modules | ||
| dist | ||
| dist-ssr | ||
| *.local | ||
|
|
||
| # Editor directories and files | ||
| .vscode/* | ||
| !.vscode/extensions.json | ||
| .idea | ||
| .DS_Store | ||
| *.suo | ||
| *.ntvs* | ||
| *.njsproj | ||
| *.sln | ||
| *.sw? |
There was a problem hiding this comment.
To be removed and merged with the root .gitignore
| { | ||
| "$schema": "./node_modules/@biomejs/biome/configuration_schema.json", | ||
| "organizeImports": { | ||
| "enabled": false | ||
| }, | ||
| "javascript": { | ||
| "formatter": { | ||
| "quoteStyle": "single", | ||
| "semicolons": "asNeeded" | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
To be replaced by eslint/prettifier
| @@ -0,0 +1,48 @@ | |||
| { | |||
There was a problem hiding this comment.
We use prettier-package-json to uniformize package.json files, see https://cristal.xwiki.org/xwiki/bin/view/Developers/CodeStyle/#Hpackage.json
You can run fd package.json -x pnpx prettier-package-json --write at the root of the project to batch format all the package.json files.
| @@ -0,0 +1,321 @@ | |||
| /* eslint-disable vue/multi-word-component-names */ | |||
There was a problem hiding this comment.
Missing license header.
| @@ -0,0 +1,28 @@ | |||
| { | |||
There was a problem hiding this comment.
This file must extend the root tsconfig.json, possibly with overriding for things specific to this package
| "react": "19.0.0", | ||
| "react-dom": "19.0.0", |
There was a problem hiding this comment.
TODO: double check that importing React in web is really required.
Moreover, if that's indeed the case, it's probably also required in the electron renderer package.
| @@ -41,6 +44,7 @@ | |||
| "baseRestURL": "/rest/cristal/page?media=json", | |||
| "homePage": "Main.WebHome", | |||
| "designSystem": "dsfr", | |||
| "editor": "tiptap", | |||
There was a problem hiding this comment.
Another option is to allow for the editor key to be missing. When undefined, the default editor (tiptap currently) is loaded.
Jira URL
https://jira.xwiki.org/browse/CRISTAL-471
Changes
Description
TODOS
Clarifications
Current content (will evolve):
config.json) now has aneditorfield to choose betweentiptapandblocknoteScreenshots & Video
Coming soon.
Executed Tests
Coming soon.
Expected merging strategy