generated from xwiki-contrib/github-template-repository
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CRISTAL-381: Make the github backend supported #687
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Working authentication * Content display * Content edition * Content deletion * Updated navigation tree to use public API * Updated history to use public API
manuelleduc
reviewed
Feb 20, 2025
core/authentication/authentication-github/src/GitHubAuthenticationManager.ts
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 20, 2025
core/authentication/authentication-github/src/GitHubAuthenticationManager.ts
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
manuelleduc
reviewed
Feb 21, 2025
core/authentication/authentication-github/src/GitHubAuthenticationManager.ts
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
core/authentication/authentication-github/src/GitHubAuthenticationManager.ts
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
core/authentication/authentication-github/src/GitHubAuthenticationManager.ts
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
core/authentication/authentication-ui/src/vue/GitHubLoginMenu.vue
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
core/authentication/authentication-ui/src/vue/GitHubLoginMenu.vue
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
manuelleduc
reviewed
Feb 21, 2025
manuelleduc
reviewed
Feb 21, 2025
core/navigation-tree/navigation-tree-github/src/components/componentsInit.ts
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 21, 2025
manuelleduc
reviewed
Feb 21, 2025
manuelleduc
reviewed
Feb 21, 2025
manuelleduc
reviewed
Feb 21, 2025
|
|
* Use Cristal's json-based page definition * Add Attachments support * Add electron support * Move GitHubLoginMenu to its own module * Introduce GitHubAuthenticationState * Add authenticationBaseURL to wiki conf * Add missing translations * Style improvements * Add comments * Small fixes
manuelleduc
reviewed
Feb 25, 2025
core/authentication/authentication-github/src/GitHubAuthenticationManager.ts
Outdated
Show resolved
Hide resolved
manuelleduc
reviewed
Feb 25, 2025
* Use DefaultPageData to store page content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/CRISTAL-381
Changes
Description
Clarifications
Login operations for the GitHub API have to be done in the backend. As such, a new backend has been implemented in
./github-authentication
. It requires to set a Client ID for a GitHub app that hasrepo:read
andrepo:write
permissions for the repository the user wants to use. This can be set in./github-authentication/src/config.ts
.While working on this issue, I noticed that the transformImage was not working properly (i.e., mutation listeners were in fact not triggered on document change). I don't know since when this happens, but I added a simpler
transformImagesInElements()
function that should have, as an added benefit, less performance impact for this purpose.Screenshots & Video
Executed Tests
Each new and changed feature was tested manually, and the current test suite was run manually.
Expected merging strategy