CRISTAL-326: Missing tooltip and hints for the create page UI #684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Introduce NavigationTreeSelect as a new form component * Add help text to TextField component * Improve form styling for Vuetify * Update hierarchy API to use EntityReferences instead of PageData * Update navigation tree API to use EntityReferences instead of PageData * Update document change API to use EntityReferences instead of PageData * Improve buttons behavior on form modals * Overall style uniformization for existing forms
manuelleduc
reviewed
Feb 19, 2025
| if (pageData != null) { | ||
| const fileHierarchy = pageData.id.split("/"); | ||
| if (page != null) { | ||
| const fileHierarchy = |
There was a problem hiding this comment.
we should introduce an API to flatten a reference in an array of segments
* Make Shoelace's breadcrumb in tree select not clickable * Add Select button to tree select
manuelleduc
reviewed
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira URL
https://jira.xwiki.org/browse/CRISTAL-326
Changes
Description
Clarifications
The main goal with this PR was to introduce a generic way to support help messages for form fields. As such, the different navigation trees used so far to "select" a node have been factorized into a cleaner NavigationTreeSelect component. The new component uses a breadcrumb to properly show the currently selected node. This, however, required some refactoring to update old APIs (created before the existence of EntityReferences) and their uses throughout the code base.
Screenshots & Video
Executed Tests
The whole test suite was executed, including integration tests.
The new component was also tested manually.
Expected merging strategy