Fixes to issue #48 #60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
including Isak's fix suggestion
first step to including a macos M1 runner
changing gsl install to the mac way of doing it with brew
Seems there is a need to remove the -l argument otherwise the macos runner will always use Python 2.7.18. See this thread for further details: actions/setup-python#179 (comment)
Just checking the Python version
Forgot to add include_dirs = tuple(include_dirs) for the Mac stuff
Looking at the issue thread with Axel, it appears that we also might need to install pymultinest with pip, thus also needing to create a new enviroment.yml file, which has pymultinest deleted?
Just updating the Issue #48 branch to be synced with main
|
Looks like something is wrong with the mamba installs will try to look into this when I am able to (probably sometime early next week) |
|
Perhaps it should be "brew install flake8 pytest" for Mac? |
|
Good point Tuomo! |
changed to brew install flake8 pytest
following Axel's suggestion
|
It appears that the NEoST install actually works for MAC M1 chips now, but the cython solvers are not "cythonizing" |
trying again...
swapped appends for extends for OS users
changing append to extend did nothing
maybe this fixes the spaces issue
adding brew install cython to see if this changes anything
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mac runner