-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PcapPlusPlus: enhance platform support and fix missing syslink on Windows #5419
Conversation
packages/p/pcapplusplus/xmake.lua
Outdated
@@ -13,18 +13,18 @@ package("pcapplusplus") | |||
|
|||
add_links("Pcap++", "Packet++", "Common++") | |||
|
|||
if is_plat("windows") then | |||
add_syslinks("ws2_32") | |||
if is_plat("windows") or is_plat("mingw") then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if is_plat("windows", "mingw") then
packages/p/pcapplusplus/xmake.lua
Outdated
end | ||
|
||
add_deps("cmake") | ||
if is_plat("windows") then | ||
if is_plat("windows") or is_plat("mingw") then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it.
It's not recommend to use precompiled binary, unless you have't skill for make package. |
Understood. In that case, could we extend support to additional platforms like macOS, FreeBSD, and Android? |
Okay, PcapPlusPlus relies on libpcap for BSD and Android, and there have been some issues with building libpcap for these targets. I am currently working on resolving these issues. |
Failed to build libpcap for the following targets, and I can not figure out why. Could it be an issue with the toolchain configuration?
|
iphlpapi
linkage on Windows
Finally successfully built libpcap on MacOS, Android, and BSD, extending PcapPlusPlus support to these platforms. |
undefined reference to `GetNetworkParams"
error by adding the missingiphlpapi
syslink, which is required for Windows.