Merge 16.0 & add 16.0-negative-unit-price-hook #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids conflicts when tests of the `account_invoice_facturx` module
run on a DB where `account_banking_sepa_direct_debit` (OCA/bank-payment)
is also installed.
In its demo data, `account_banking_sepa_direct_debit` changes the
payment method of the partner used in this test to a SEPA one which has
no UNECE code by default (guess it should have one, but that's another
issue).
The same partner is used in this test; leads to error:
```
ERROR: TestFacturXInvoice.test_deep_customer_invoice
Traceback (most recent call last):
File "/opt/odoo/lib/python3.10/site-packages/odoo/addons/account_invoice_facturx/tests/test_facturx_invoice.py", line 93, in test_deep_customer_invoice
xml_bytes, fx_level = self.invoice.generate_facturx_xml()
File "/opt/odoo/lib/python3.10/site-packages/odoo/addons/account_invoice_facturx/models/account_move.py", line 871, in generate_facturx_xml
self._cii_add_trade_settlement_block(trade_transaction, ns)
File "/opt/odoo/lib/python3.10/site-packages/odoo/addons/account_invoice_facturx/models/account_move.py", line 498, in _cii_add_trade_settlement_block
raise UserError(
odoo.exceptions.UserError: Missing UNECE code on payment method '[sepa_direct_debit] SEPA Direct Debit for customers (inbound)'
```
This allows negative unit prices in specific cases.
vincent-hatakeyama
force-pushed
the
xcg/16.0
branch
from
119ac80 to
070ffa4
Compare
vincent-hatakeyama
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OCA#953