add global configuration for node key generation and update clone fun…

…ction to use it

packages/mobx-bonsai/src/globalConfig.ts

@@ -0,0 +1,37 @@
+import { NodeKeyGenerator, defaultNodeKeyGenerator } from "./node/utils/nodeKeyGenerator"
+
+/**
+ * Global config object.
+ */
+export interface GlobalConfig {
+  /**
+   * Node key generator function.
+   */
+  keyGenerator: NodeKeyGenerator
+}
+
+// defaults
+let globalConfig: GlobalConfig = {
+  keyGenerator: defaultNodeKeyGenerator,
+}
+
+/**
+ * Partially sets the current global config.
+ *
+ * @param config Partial object with the new configurations. Options not included in the object won't be changed.
+ */
+export function setGlobalConfig(config: Partial<GlobalConfig>) {
+  globalConfig = Object.freeze({
+    ...globalConfig,
+    ...config,
+  })
+}
+
+/**
+ * Returns the current global config object.
+ *
+ * @returns
+ */
+export function getGlobalConfig(): Readonly<GlobalConfig> {
+  return globalConfig
+}

packages/mobx-bonsai/src/node/clone.ts

@@ -1,17 +1,17 @@
 import { failure } from "../error/failure"
+import { getGlobalConfig } from "../globalConfig"
 import { isPlainObject, isPrimitive } from "../plainTypes/checks"
 import { node } from "./node"
 import { getNodeTypeAndKey } from "./nodeTypeKey"
 import { getSnapshot } from "./snapshot/getSnapshot"
-import { NodeKeyGenerator, defaultNodeKeyGenerator } from "./utils/nodeKeyGenerator"
 
-function deepSubstituteNodeKeys<T>(value: T, nodeKeyGenerator: NodeKeyGenerator): T {
+function deepSubstituteNodeKeys<T>(value: T): T {
   if (isPrimitive(value)) {
     return value
   }
 
   if (Array.isArray(value)) {
-    return value.map((v) => deepSubstituteNodeKeys(v, nodeKeyGenerator)) as T
+    return value.map((v) => deepSubstituteNodeKeys(v)) as T
   }
 
   if (isPlainObject(value)) {
@@ -21,9 +21,9 @@ function deepSubstituteNodeKeys<T>(value: T, nodeKeyGenerator: NodeKeyGenerator)
     const newValue: any = {}
     for (const key in value) {
       if (key === keyProp) {
-        newValue[key] = nodeKeyGenerator()
+        newValue[key] = getGlobalConfig().keyGenerator()
       } else {
-        newValue[key] = deepSubstituteNodeKeys(value[key], nodeKeyGenerator)
+        newValue[key] = deepSubstituteNodeKeys(value[key])
       }
     }
     return newValue
@@ -36,14 +36,10 @@ function deepSubstituteNodeKeys<T>(value: T, nodeKeyGenerator: NodeKeyGenerator)
  * Clones a node. It will generate new node keys deeply.
  *
  * @param nodeToClone Node to clone.
- * @param nodeKeyGenerator Optional node key generator.
  * @returns The cloned node.
  */
-export function clone<T extends object>(
-  nodeToClone: T,
-  nodeKeyGenerator = defaultNodeKeyGenerator
-): T {
-  const snapshotWithChangedKeys = deepSubstituteNodeKeys(getSnapshot(nodeToClone), nodeKeyGenerator)
+export function clone<T extends object>(nodeToClone: T): T {
+  const snapshotWithChangedKeys = deepSubstituteNodeKeys(getSnapshot(nodeToClone))
 
   return node(snapshotWithChangedKeys)
 }

packages/mobx-bonsai/test/commonSetup.ts

@@ -1,3 +1,16 @@
 import { configure } from "mobx"
+import { setGlobalConfig } from "../src/globalConfig"
 
 configure({ enforceActions: "always" })
+
+let id = 1
+
+setGlobalConfig({
+  keyGenerator() {
+    return `id-${id++}`
+  },
+})
+
+beforeEach(() => {
+  id = 1
+})