Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Organization in pre-issue access token Request. #2742

Merged

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla Thisara-Welmilla commented Mar 10, 2025

Issue:

In the pre-issue access token extension for a sub-organization context, consider the following for the organization sent in the request to an external service:

  1. The organization must be a sub-organization of the authorization server to which the application belongs.
  2. Currently, pre-issue access tokens are not available for sub-organizations.
  3. Therefore, the authorization server will always be the root tenant.

Given the above, the organization sent in the request to the external service will always be null.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13756292976

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.67%. Comparing base (07d921a) to head (117ba12).
Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2742      +/-   ##
============================================
+ Coverage     56.23%   56.67%   +0.44%     
+ Complexity     8787     8644     -143     
============================================
  Files           654      654              
  Lines         50304    48991    -1313     
  Branches      10584    10358     -226     
============================================
- Hits          28290    27768     -522     
+ Misses        17972    17298     -674     
+ Partials       4042     3925     -117     
Flag Coverage Δ
unit 40.07% <ø> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Thisara-Welmilla Thisara-Welmilla changed the title Re-purpose Organization in pre-issue access token Request. Remove Organization in pre-issue access token Request. Mar 10, 2025
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13757561372

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13757561372
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13757561372

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13756292976
Status: cancelled

@malithie malithie merged commit 05189c2 into wso2-extensions:master Mar 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants