Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to new request builder and processor contracts. #2719

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

malithie
Copy link
Contributor

Proposed changes in this pull request

Related to wso2/product-is#23108

This PR utilizes the new ActionExecutionRequestBuilder and ResponseProcessor contracts for pre issue access token action implementation.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/13377896891

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

Attention: Patch coverage is 8.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.47%. Comparing base (ba31964) to head (ed111f7).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
...xecution/PreIssueAccessTokenResponseProcessor.java 0.00% 6 Missing ⚠️
...dlers/grant/AbstractAuthorizationGrantHandler.java 0.00% 3 Missing ⚠️
...uth2/token/handlers/grant/RefreshGrantHandler.java 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (8.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #2719      +/-   ##
============================================
- Coverage     56.47%   56.47%   -0.01%     
- Complexity     8548     8568      +20     
============================================
  Files           654      654              
  Lines         48679    48758      +79     
  Branches      10152    10229      +77     
============================================
+ Hits          27491    27534      +43     
- Misses        17274    17295      +21     
- Partials       3914     3929      +15     
Flag Coverage Δ
unit 39.95% <8.33%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/13377896891
Status: success

Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/13377896891

@malithie malithie merged commit c7a616d into wso2-extensions:master Feb 18, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants