-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement/7349: Add filter to select delayjs script #7350
base: develop
Are you sure you want to change the base?
Enhancement/7349: Add filter to select delayjs script #7350
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
@wp-media/qa-team would it be possible for one of you to run the e2e tests on it to look for regressions? |
Description
Fixes #7349
Added a filter to handle regression easier by letting the client select his delay js script.
Type of change
Detailed scenario
What was tested
Describe the scenarios that you tested, and specify if it is automated or manual. For manual scenarios, provide a screenshot of the results.
I created an integration scenarios for the matching logic.
How to test
Describe how the PR can be tested so that the validator can be autonomous: environment, dependencies, specific setup, steps to perform, API requests, etc.
Execute the tests.
Use the filter
rocket_delay_js_version_js_script
with a callback to change the version and observe the script being sered.Technical description
Documentation
Explain how this code works. Diagrams & drawings are welcome.
It just adds a new filter
rocket_delay_js_version_js_script
to add inside the Notion doc.New dependencies
List any new dependencies that are required for this change.
Risks
List possible performance & security issues or risks, and explain how they have been mitigated.
Mandatory Checklist
Code validation
Code style
Unticked items justification
If some mandatory items are not relevant, explain why in this section.
Additional Checks