-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[보스독] 4단계 - HTTP 웹 서버 리팩토링 미션 제출합니다. #187
Open
yeonnseok
wants to merge
10
commits into
woowacourse:yeonnseok
Choose a base branch
from
yeonnseok:bossdog
base: yeonnseok
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
867e493
docs: 요구사항 업데이트
yeonnseok 2243e0f
refactor: 멀티모듈로 분리
yeonnseok f8110e1
refactor: gradle 의존성 수정
yeonnseok 6116942
refactor: JSESSIONID 하드코딩 상수화
yeonnseok f7d1322
refactor: 의미없는 쿠키 검증 제거
yeonnseok 94968c5
refactor: 한 요청에 대해서 쿠키와 response 싱크 맞추기
yeonnseok e242adf
refactor: 공통 gradle 설정 root level로 추출
yeonnseok 83c9081
refactor: web-common 이름 web-domain으로 변경
yeonnseok 4054c34
refactor: web-session 모듈 분리
yeonnseok ae4f028
docs: 각 모듈의 README.md 파일 작성
yeonnseok File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,56 @@ | ||
buildscript { | ||
ext { | ||
springBootVersion = '2.2.2.RELEASE' | ||
} | ||
repositories { | ||
mavenCentral() | ||
} | ||
dependencies { | ||
classpath("org.springframework.boot:spring-boot-gradle-plugin:${springBootVersion}") | ||
} | ||
} | ||
|
||
plugins { | ||
id 'java' | ||
id 'idea' | ||
id 'eclipse' | ||
} | ||
|
||
allprojects { | ||
version = '1.0.0' | ||
} | ||
|
||
subprojects { | ||
apply plugin: 'java' | ||
apply plugin: 'idea' | ||
apply plugin: 'eclipse' | ||
|
||
sourceCompatibility = 1.8 | ||
|
||
repositories { | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
implementation 'ch.qos.logback:logback-classic:1.2.3' | ||
testImplementation 'org.junit.jupiter:junit-jupiter:5.6.2' | ||
testImplementation 'org.assertj:assertj-core:3.16.1' | ||
} | ||
|
||
test { | ||
useJUnitPlatform() | ||
} | ||
} | ||
|
||
project(':web-server') { | ||
dependencies { | ||
compile project(':web-common') | ||
} | ||
} | ||
|
||
project(':service-app') { | ||
dependencies { | ||
compile project(':web-common') | ||
compile project(':web-server') | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,25 +1,3 @@ | ||
plugins { | ||
id 'java' | ||
id 'idea' | ||
id 'eclipse' | ||
} | ||
|
||
version = '1.0.0' | ||
sourceCompatibility = 1.8 | ||
|
||
repositories { | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
implementation project (':web-server') | ||
implementation project (':web-common') | ||
implementation 'com.google.guava:guava:29.0-jre' | ||
implementation 'ch.qos.logback:logback-classic:1.2.3' | ||
testImplementation 'org.junit.jupiter:junit-jupiter:5.6.2' | ||
testImplementation 'org.assertj:assertj-core:3.16.1' | ||
} | ||
|
||
test { | ||
useJUnitPlatform() | ||
} |
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,5 @@ | ||
plugins { | ||
id 'java' | ||
id 'idea' | ||
id 'eclipse' | ||
} | ||
|
||
version = '1.0.0' | ||
sourceCompatibility = 1.8 | ||
|
||
repositories { | ||
mavenCentral() | ||
} | ||
|
||
dependencies { | ||
implementation project (':web-common') | ||
implementation 'com.google.guava:guava:29.0-jre' | ||
implementation 'ch.qos.logback:logback-classic:1.2.3' | ||
implementation 'com.github.jknack:handlebars:4.2.0' | ||
implementation 'org.springframework:spring-core:5.2.6.RELEASE' | ||
testImplementation 'org.junit.jupiter:junit-jupiter:5.6.2' | ||
testImplementation 'org.assertj:assertj-core:3.16.1' | ||
} | ||
|
||
test { | ||
useJUnitPlatform() | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
각 모듈의 설정까지 뺄 필요는 없을 것 같아요 :)