-
Notifications
You must be signed in to change notification settings - Fork 272
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ 지하철 노선도 미션 ] 박민영 미션 제출합니다. #116
Open
Gomding
wants to merge
49
commits into
woowacourse:main
Choose a base branch
from
Gomding:parkminyoung
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
지하철 노선에 구간을 추가할 때 입력한 역 이름이 StationRepository에 존재하는지 검사하는 기능 추가
클래스명 변경 : SubwayMap -> MainMenu 패키지명 변경 : map -> menu
StationRepository - stationList 를 ArrayList에서 LinkedList로 변경 Line - stationList와 관련 기능을 없애고 StationRepository 타입의 변수를 추가
도메인 간의 순서를 보장해주기 위한 Service 추가
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
3주간 정말 감사했습니다.
남은 시간이 없어서 코드를 더 깔끔하게 만들지 못해 밤잠을 이루지 못할것 같습니다.
부족한 부분은 프리코스가 끝나더라도 과제를 좀 더 완성시켜보고 싶습니다.
이번 3주차 미션을 하면서 구현하다보니 점점 MVC 구조와 닮아가고 있어서
중간에 MVC 구조로 바꿔서 구현하느라 시간이 좀 더 걸렸습니다.
구현하면서 구조에 대해 생각하며 코드들이 있어야할 자리에대해 많은 고민을 했습니다.
좋은 과제를 내주셔서 정말 감사합니다!