feat: 채팅 목록 조회 시 최신순 정렬 적용 #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masonkimseoul
commented
Oct 17, 2024
Comment on lines
+13
to
+23
| public int compareTo(CommentLatestResponse other) { | ||
| if (this.createdAt == null && other.createdAt == null) { | ||
| return 0; | ||
| } | ||
| if (this.createdAt == null) { | ||
| return 1; | ||
| } | ||
| if (other.createdAt == null) { | ||
| return -1; | ||
| } | ||
| return other.createdAt.compareTo(this.createdAt); |
There was a problem hiding this comment.
Comment가 없는 경우 null 처리를 하셨군요~
fromitive
reviewed
Oct 17, 2024
Comment on lines
64
to
67
| assertEquals(response.offerings().get(0).offeringId(), 2L); | ||
| assertEquals(response.offerings().get(1).offeringId(), 1L); | ||
| assertEquals(response.offerings().get(2).offeringId(), 3L); | ||
| assertEquals(response.offerings().get(3).offeringId(), 4L); |
fromitive
requested changes
Oct 17, 2024
fromitive
pushed a commit
that referenced
this pull request
Nov 28, 2024
* feat: CommentRoom 정렬 방식 변경 * fix: null 일 땐 맨 아래에 배치하도록 정렬 로직 수정 * test: 잘못 들어온 contextLoads 테스트 제거 * test: 순서 보장 테스트에 containsExactly 사용 --------- Co-authored-by: Choo <choo000407@naver.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📌 관련 이슈
close #593
✨ 작업 내용
📚 기타