Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 모집 마감 상태 스타일 미적용 해결 #591

Merged
merged 1 commit into from
Oct 17, 2024
Merged

fix: 모집 마감 상태 스타일 미적용 해결 #591

merged 1 commit into from
Oct 17, 2024

Conversation

fromitive
Copy link
Contributor

@fromitive fromitive commented Oct 17, 2024 •
edited
Loading

📌 관련 이슈

close #590

✨ 작업 내용

  • web에서 인원 만석, 모집 마감 상태가 제대로 반영되지 않은 문제가 있었어요~
  • 없는 상태값인 CLOSED를 비교해서 스타일이 제대로 적용되지 않았어요
  • OfferingStatus 값을 확인하고 CLOSED를 CONFIRMED로 변경해서 해결했습니다~
image

📚 기타

helenason
helenason approved these changes Oct 17, 2024
View reviewed changes
Copy link
Contributor

@helenason helenason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 수고했어요 프론트 포케

masonkimseoul
masonkimseoul approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@masonkimseoul masonkimseoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

backend/src/main/resources/templates/index.html
@@ -279,7 +279,7 @@
if (offering.status === 'IMMINENT') {
statusClass = 'status-imminent';
statusName = '마감임박';
} else if (offering.status === 'CLOSED') {
} else if (offering.status === 'CONFIRMED') {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Human Issue 였군요~ 확인했습니다.

@helenason helenason merged commit a67d9ae into develop Oct 17, 2024
@helenason helenason deleted the feature/590-fix-web-offring-status-style branch October 17, 2024 07:15
fromitive added a commit that referenced this pull request Nov 28, 2024
@fromitive
fix: 모집 마감 상태 스타일 미적용 해결 (#591)
6feea20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masonkimseoul masonkimseoul masonkimseoul approved these changes

@helenason helenason helenason approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

⚡ [총대마켓 웹] 모집 마감 상태 스타일 미적용 해결
3 participants
@fromitive @masonkimseoul @helenason