Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding VersionStream for kafka-4.0 #48244

Merged
merged 5 commits into from
Mar 26, 2025
Merged

Adding VersionStream for kafka-4.0 #48244

merged 5 commits into from
Mar 26, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Mar 26, 2025

No description provided.

Copy link
Contributor Author

octo-sts bot commented Mar 26, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: "Hunk #1 FAILED at 141... 1 out of 1 hunk FAILED -- saving rejects to file gradle/dependencies.gradle.rej"

• Error Category: Configuration/Patch

• Failure Point: The patch command failed to apply GHSA-4g8c-wm8x-jfhw-fix.patch to gradle/dependencies.gradle

• Root Cause Analysis: The patch is failing to apply cleanly because the target file content doesn't match the patch's expectations. This typically happens when:

  1. The patch was created for a different version of the file
  2. Line numbers or context don't match
  3. The file has been modified from its original state

• Suggested Fix:

  1. Verify the patch content matches the target version:
# Check the actual file content
git show 4.0.0:gradle/dependencies.gradle

# Create a new patch by manually applying the security fix:
1. Check the GHSA advisory details
2. Manually modify gradle/dependencies.gradle
3. Generate a new patch:
git diff > new-GHSA-4g8c-wm8x-jfhw-fix.patch

• Explanation: The patch is failing because it was likely created against a different version of the Kafka codebase. Creating a new patch that matches the exact version being built (4.0.0) will ensure proper application.

• Additional Notes:

  • The tag checkout was successful (985bc99521dd22bbf620591b8db8613c54f596b2)
  • The security patch is important as it references a GHSA (GitHub Security Advisory)
  • Consider adding patch fuzz factor if the changes are minor:
    - uses: patch
      with:
        patches: GHSA-4g8c-wm8x-jfhw-fix.patch
        args: [-p1, -F3]  # Allow 3 lines of fuzz

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Mar 26, 2025
@OddBloke OddBloke self-assigned this Mar 26, 2025
@OddBloke OddBloke force-pushed the kafka-4.0 branch 3 times, most recently from f59c80d to 0184822 Compare March 26, 2025 12:24
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 26, 2025
octo-sts bot and others added 5 commits March 26, 2025 10:04
4.0 is the latest version for now, so lets always pull the most recent
definitions until that is no longer the case.
Zookeeper support has been dropped entirely, so move to a KRaft setup.
This is heavily inspired by the existing tests in the confluent-kafka
package.
@OddBloke OddBloke requested a review from a team March 26, 2025 14:44
@OddBloke OddBloke enabled auto-merge March 26, 2025 14:44
@OddBloke OddBloke merged commit c584724 into main Mar 26, 2025
28 checks passed
@OddBloke OddBloke deleted the kafka-4.0 branch March 26, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. service:version-stream
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants