-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding VersionStream for kafka-4.0 #48244
Conversation
Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation. To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify: e.g. /ai-verify partially helpful but I also added bash to the build environment Gen AI suggestions to solve the build error: • Detected Error: "Hunk #1 FAILED at 141... 1 out of 1 hunk FAILED -- saving rejects to file gradle/dependencies.gradle.rej" • Error Category: Configuration/Patch • Failure Point: The patch command failed to apply GHSA-4g8c-wm8x-jfhw-fix.patch to gradle/dependencies.gradle • Root Cause Analysis: The patch is failing to apply cleanly because the target file content doesn't match the patch's expectations. This typically happens when:
• Suggested Fix:
# Check the actual file content
git show 4.0.0:gradle/dependencies.gradle
# Create a new patch by manually applying the security fix:
1. Check the GHSA advisory details
2. Manually modify gradle/dependencies.gradle
3. Generate a new patch:
git diff > new-GHSA-4g8c-wm8x-jfhw-fix.patch • Explanation: The patch is failing because it was likely created against a different version of the Kafka codebase. Creating a new patch that matches the exact version being built (4.0.0) will ensure proper application. • Additional Notes:
• References:
|
f59c80d
to
0184822
Compare
4.0 is the latest version for now, so lets always pull the most recent definitions until that is no longer the case.
Zookeeper support has been dropped entirely, so move to a KRaft setup. This is heavily inspired by the existing tests in the confluent-kafka package.
No description provided.