Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab-runner-17.9/17.9.2 package update #47512

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

octo-sts[bot]
Copy link
Contributor

@octo-sts octo-sts bot commented Mar 20, 2025

Signed-off-by: wolfi-bot <121097084+wolfi-bot@users.noreply.github.com>
@octo-sts octo-sts bot added request-version-update request for a newer version of a package automated pr labels Mar 20, 2025
Copy link
Contributor Author

octo-sts bot commented Mar 20, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

Based on the error output, I'll analyze and provide a solution:

• Detected Error:

warning: refs/tags/v17.9.2 765eed7b2e89457f1e7c224ac35c67f3fa6e6434 is not a commit!

• Error Category: Version/Git

• Failure Point: Git checkout step trying to fetch tag v17.9.2

• Root Cause Analysis: The expected commit hash in the melange.yaml (14c5775c90a9b544dccd0070b35dd47f56bf164d) doesn't match with the actual commit hash for the v17.9.2 tag (765eed7b2e89457f1e7c224ac35c67f3fa6e6434)

• Suggested Fix:
Update the expected-commit hash in the git-checkout step:

- uses: git-checkout
  with:
    repository: https://gitlab.com/gitlab-org/gitlab-runner
    tag: v${{package.version}}
    expected-commit: 765eed7b2e89457f1e7c224ac35c67f3fa6e6434

• Explanation: The build is failing because the melange.yaml file has an incorrect expected commit hash for the v17.9.2 tag. When upgrading package versions, it's necessary to update the expected-commit hash to match the actual commit that the tag points to in the upstream repository.

• Additional Notes:

  • Always verify the commit hash when updating package versions
  • You can get the correct commit hash using: git ls-remote https://gitlab.com/gitlab-org/gitlab-runner refs/tags/v17.9.2
  • Consider automating the commit hash verification as part of the version bump process

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Mar 20, 2025
@amberarcadia amberarcadia self-assigned this Mar 20, 2025
@octo-sts octo-sts bot added the bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. label Mar 20, 2025
@amberarcadia amberarcadia requested a review from a team March 20, 2025 14:20
@amberarcadia amberarcadia merged commit 7d2464d into main Mar 20, 2025
21 checks passed
@amberarcadia amberarcadia deleted the wolfictl-86289e37-3bfe-47e7-9926-dfc2ed3e50dd branch March 20, 2025 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR automated pr bincapz/pass bincapz/pass Bincapz (aka. malcontent) scan didn't detect any CRITICALs on the scanned packages. manual/review-needed request-version-update request for a newer version of a package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants