Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flannel package enhancements misconfigured version setting + tests #47460

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

rahulduvedi
Copy link
Contributor

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

flannel.yaml Outdated
flanneld --help

# Start etcd (default v3)
mkdir -p /var/lib/etcd
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can consider using test/daemon-check-output pipeline here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for suggesting, I have updated the code to use test/demon-check-output pipeline.

@rahulduvedi rahulduvedi requested a review from kranurag7 March 20, 2025 07:48
wojciechka
wojciechka previously approved these changes Mar 20, 2025
@maxgio92
Copy link
Member

This is awesome

@rahulduvedi rahulduvedi changed the title Flannel Flannel package enhancements misconfigured version setting + tests Mar 20, 2025
rahulduvedi and others added 2 commits March 21, 2025 20:08
Co-authored-by: maxgio92 <me@maxgio.it>
Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it>
Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
rahulduvedi and others added 3 commits March 21, 2025 20:09
Co-authored-by: maxgio92 <me@maxgio.it>
Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it>
Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it>
Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants