-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flannel package enhancements misconfigured version setting + tests #47460
base: main
Are you sure you want to change the base?
Conversation
flannel.yaml
Outdated
flanneld --help | ||
|
||
# Start etcd (default v3) | ||
mkdir -p /var/lib/etcd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can consider using test/daemon-check-output pipeline here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for suggesting, I have updated the code to use test/demon-check-output pipeline.
Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
This is awesome |
Co-authored-by: maxgio92 <me@maxgio.it> Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it> Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it> Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it> Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Co-authored-by: maxgio92 <me@maxgio.it> Signed-off-by: Rahul Duvedi <53002164+rahulduvedi@users.noreply.github.com>
Fixes:
Related:
Pre-review Checklist
For new package PRs only
endoflife.date
)For new version streams
name: ${{package.name}}-compat
)provides:
logical unversioned forms of the package (e.g.nodejs
,nodejs-lts
)For package updates (renames) in the base images
When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)
apk upgrade --latest
successfully upgrades packages or performs no actionsFor security-related PRs
For version bump PRs
epoch
field is reset to 0For PRs that add patches