Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new mysql-shell #47442

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Aditvil-Dev
Copy link
Member

Fixes:

Related:

Pre-review Checklist

For new package PRs only

  • This PR is marked as fixing a pre-existing package request bug
    • Alternatively, the PR is marked as related to a pre-existing package request bug, such as a dependency
  • REQUIRED - The package is available under an OSI-approved or FSF-approved license
  • REQUIRED - The version of the package is still receiving security updates
  • This PR links to the upstream project's support policy (e.g. endoflife.date)

For new version streams

  • The upstream project actually supports multiple concurrent versions.
  • Any subpackages include the version string in their package name (e.g. name: ${{package.name}}-compat)
  • The package (and subpackages) provides: logical unversioned forms of the package (e.g. nodejs, nodejs-lts)
  • If non-streamed package names no longer built, open PR to withdraw them (see WITHDRAWING PACKAGES)

For package updates (renames) in the base images

When updating packages part of base images (i.e. cgr.dev/chainguard/wolfi-base or ghcr.io/wolfi-dev/sdk)

  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk images successfully build
  • REQUIRED cgr.dev/chainguard/wolfi-base and ghcr.io/wolfi-dev/sdk contain no obsolete (no longer built) packages
  • Upon launch, does apk upgrade --latest successfully upgrades packages or performs no actions

For security-related PRs

  • The security fix is recorded in the advisories repo

For version bump PRs

  • The epoch field is reset to 0

For PRs that add patches

  • Patch source is documented

Signed-off-by: Aditvil-Dev <aditya.tirmanwar@chainguard.dev>
Copy link
Contributor

octo-sts bot commented Mar 19, 2025

⚠️ EXPERIMENTAL

Please use 👍 or 👎 on this comment to indicate if you agree or disagree with the recommendation.

To provide more detailed feedback please comment on the recommendation prefixed with /ai-verify:

e.g. /ai-verify partially helpful but I also added bash to the build environment

Gen AI suggestions to solve the build error:

• Detected Error: "FILE STRINGS file '/usr/MYSQL_VERSION' cannot be read" followed by "MYSQL_VERSION file for server cannot be parsed."

• Error Category: Configuration/Build

• Failure Point: CMake configuration step, specifically when trying to read MySQL version information

• Root Cause Analysis: The build is failing because CMake cannot find the MYSQL_VERSION file in the specified MySQL source directory. The current configuration is looking for version information in /usr but the MySQL development files may be installed in a different location.

• Suggested Fix:

  1. Modify the MYSQL_SOURCE_DIR environment variable in the melange YAML:
environment:
  environment:
    MYSQL_SOURCE_DIR: /usr/include/mysql
    MYSQL_BUILD_DIR: /usr/include/mysql
  1. Add additional CMake options:
  - uses: cmake/configure
    with:
      opts: |
        -DMYSQL_SOURCE_DIR=$MYSQL_SOURCE_DIR \
        -DMYSQL_BUILD_DIR=$MYSQL_BUILD_DIR \
        -DCMAKE_INSTALL_PREFIX=/usr \
        -DHAVE_PYTHON=1 \
        -DWITH_SSL=system \
        -DWITH_TESTS=OFF \
        -DMYSQL_VERSION_MAJOR=9 \
        -DMYSQL_VERSION_MINOR=1 \
        -DMYSQL_VERSION_PATCH=0

• Explanation: MySQL Shell's build system expects to find MySQL server source files to determine version information. Since we're building against installed development headers rather than full source, we need to point to the correct location and potentially provide version information explicitly through CMake options.

• Additional Notes:

  • The mysql-9.1-dev package typically installs headers in /usr/include/mysql
  • Version information might need to be provided explicitly since we're not building against full source
  • Consider adding mysql-9.1-common as a build dependency if it exists

• References:

@octo-sts octo-sts bot added the ai/skip-comment Stop AI from commenting on PR label Mar 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ai/skip-comment Stop AI from commenting on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant