default to running tests on the docker runner #14707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshrwolf
force-pushed
the
default-test-to-docker
branch
30 times, most recently
from
573625a to
8aa67ed
Compare
joshrwolf
force-pushed
the
default-test-to-docker
branch
2 times, most recently
from
3b776df to
1b4c7cb
Compare
Signed-off-by: Josh Wolf <josh@wolfs.io>
joshrwolf
force-pushed
the
default-test-to-docker
branch
from
1b4c7cb to
9f98034
Compare
jonjohnsonjr
approved these changes
Mar 12, 2024
This was referenced Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the default
melange test ...to use the docker runner by default instead ofbwrap.We're still relatively greenfield with our tests (compared to our builds), so this seems like the right time if any to make a change like this. Because of what tests are,
dockerfeels like a better fit for the runtime, being a full container runtime instead of a light weight sandboxing tool.I had to plumb through the appropriate bind mount dirs because of how GHA by default mounts the docker socket, so this impl has a bit of nastiness around the
TMPDIR=/temp make test/.... I left an inline comment to warn future readers.This only touches
melange test, but should be similar formelange build, but that requires a more complicated migration and validation given the blissful ignorance we've been living in where all runners created workspace is solved and packaged equally.To prove this works, I migrated the #14496 as part of this PR, which is part of #13623