Fix progress active set in tick (#20)

* Fixed setting progress.active inside tick to flip to true when inside root * 0.4.10
wix-incubator · Feb 19, 2025 · f028c8e · f028c8e
1 parent 85a09cf
commit f028c8e
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 9 deletions.
diff --git a/dist/index.cjs b/dist/index.cjs
@@ -354,8 +354,8 @@ function getController$1 (config) {
 
         const velocity = {x: progress.vx, y: progress.vy};
 
-        if (config.allowActiveEvent && (normalizedX > 1 || normalizedY > 1 || normalizedX < 0 || normalizedY < 0)) {
-          progress.active = false;
+        if (config.allowActiveEvent) {
+          progress.active = (normalizedX <= 1 && normalizedY <= 1 && normalizedX >= 0 && normalizedY >= 0);
         }
 
         // run effect

diff --git a/docs/demo/index.js b/docs/demo/index.js
@@ -352,8 +352,8 @@ function getController$1 (config) {
 
         const velocity = {x: progress.vx, y: progress.vy};
 
-        if (config.allowActiveEvent && (normalizedX > 1 || normalizedY > 1 || normalizedX < 0 || normalizedY < 0)) {
-          progress.active = false;
+        if (config.allowActiveEvent) {
+          progress.active = (normalizedX <= 1 && normalizedY <= 1 && normalizedX >= 0 && normalizedY >= 0);
         }
 
         // run effect

diff --git a/docs/reference/index.html b/docs/reference/index.html
@@ -2,7 +2,7 @@
 <html lang="en">
 <head>
   <meta charset='utf-8'>
-  <title>kuliso 0.4.8 | Documentation</title>
+  <title>kuliso 0.4.9 | Documentation</title>
   <meta name='description' content='Tiny library for performant pointer-driven or gyroscope-driven effects'>
   <meta name='viewport' content='width=device-width,initial-scale=1'>
   <link href='assets/bass.css' rel='stylesheet'>
@@ -15,7 +15,7 @@
       <div id='split-left' class='overflow-auto fs0 height-viewport-100'>
         <div class='py1 px2'>
           <h3 class='mb0 no-anchor'>kuliso</h3>
-          <div class='mb1'><code>0.4.8</code></div>
+          <div class='mb1'><code>0.4.9</code></div>
           <input
             placeholder='Filter'
             id='filter-input'

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "kuliso",
-  "version": "0.4.9",
+  "version": "0.4.10",
   "sideeffects": true,
   "description": "Tiny library for performant pointer-driven or gyroscope-driven effects",
   "main": "dist/index.cjs",

diff --git a/src/controller.js b/src/controller.js
@@ -135,8 +135,8 @@ export function getController (config) {
 
         const velocity = {x: progress.vx, y: progress.vy};
 
-        if (config.allowActiveEvent && (normalizedX > 1 || normalizedY > 1 || normalizedX < 0 || normalizedY < 0)) {
-          progress.active = false;
+        if (config.allowActiveEvent) {
+          progress.active = (normalizedX <= 1 && normalizedY <= 1 && normalizedX >= 0 && normalizedY >= 0);
         }
 
         // run effect