Add translators for the sbcu and dbcu sectors #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to a draft, since the wcxf-bases submodule will need to be updated as well before this should be merged |
|
Hi Matthew, I can click the "merge" button on the bases PR but I have not reviewed it. I assume it's just a copy/paste of an existing sector with different flavour indices? |
|
Yep, it is just a copy/paste, so that should be a trivial approval. I just eyeballed it again as well and it looks fine |
|
Shouldn't be merged until my sign change in the wcxf basis (wcxf/wcxf-bases#15) is merged, and then the wcxf-bases submodule updated. |
MJKirk
force-pushed
the
sbcu-dbcu-translators
branch
from
874225f to
b0c6d03
Compare
MJKirk
force-pushed
the
sbcu-dbcu-translators
branch
from
b0c6d03 to
710acc7
Compare
MJKirk
force-pushed
the
sbcu-dbcu-translators
branch
from
710acc7 to
3abaaa4
Compare
peterstangl
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relies on my PR in wcxf-bases (wcxf/wcxf-bases#10) adding these new sectors