Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T374012 #5204

Open
wants to merge 7 commits into
base: temp-accounts
Choose a base branch
from
Open

T374012 #5204

wants to merge 7 commits into from

Conversation

l-olson1214
Copy link
Collaborator

@l-olson1214 l-olson1214 commented Feb 19, 2025 •
edited
Loading

Phabricator:
https://phabricator.wikimedia.org/T374012

Notes

  • Updated navigation bar
  • Update to use coordinator

Test Steps

  1. Using a temporary account, Test language
  2. Navigate to article
  3. Press pencil button (unlocked)
  4. Make sure temporary account sheet shows, press Done
  5. Ensure the temporary account icon shows, tap it
  6. Ensure temporary account sheet shows
  7. Repeat steps with IP account

Screenshots/Videos

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-19.at.16.08.26.mp4
Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-02-19.at.15.59.21.mp4

@l-olson1214 l-olson1214 requested review from a team and mazevedofs and removed request for a team February 19, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mazevedofs mazevedofs Awaiting requested review from mazevedofs mazevedofs was automatically assigned from wikimedia/ios

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@l-olson1214